[#267] Created PartijIdentificatorUniquenessValidatorTests

Author: danielmursa-dev

src/openklant/components/klantinteracties/api/serializers/partijen.py

@@ -365,7 +365,16 @@ class PartijIdentificatorGroepTypeSerializer(GegevensGroepSerializer):
     class Meta:
         model = PartijIdentificator
         gegevensgroep = "partij_identificator"
-        validators = []
+        extra_kwargs = {
+            "code_register": {"required": True},
+            "code_objecttype": {"required": True},
+            "code_soort_object_id": {"required": True},
+            "object_id": {"required": True},
+        }
+
+    def validate(self, attrs):
+        PartijIdentificatorTypesValidator(partij_identificator=attrs).validate()
+        return super().validate(attrs)
 
 
 class PartijIdentificatorSerializer(
@@ -414,13 +423,12 @@ def validate(self, attrs):
         instance = getattr(self, "instance", None)
         partij_identificator = get_field_value(self, attrs, "partij_identificator")
         sub_identificator_van = get_field_value(self, attrs, "sub_identificator_van")
-        if sub_identificator_van:
+        partij = get_field_value(self, attrs, "partij")
+        if "sub_identificator_van" in attrs and sub_identificator_van:
             sub_identificator_van = PartijIdentificator.objects.get(
                 uuid=sub_identificator_van["uuid"]
             )
-        PartijIdentificatorTypesValidator(
-            partij_identificator=partij_identificator
-        ).validate()
+
         PartijIdentificatorUniquenessValidator(
             queryset=(
                 PartijIdentificator.objects.exclude(pk=instance.pk)
@@ -437,7 +445,12 @@ def validate(self, attrs):
     def update(self, instance, validated_data):
         if partij := validated_data.get("partij", None):
             validated_data["partij"] = Partij.objects.get(uuid=partij["uuid"])
-
+        # TODO FAI QUESTO test
+        breakpoint()
+        if sub_identificator_van := validated_data.get("sub_identificator_van", None):
+            validated_data["sub_identificator_van"] = PartijIdentificator.objects.get(
+                uuid=sub_identificator_van["uuid"]
+            )
         return super().update(instance, validated_data)
 
     @transaction.atomic

src/openklant/components/klantinteracties/api/tests/test_partijen.py

@@ -0,0 +1,30 @@
+# Generated by Django 4.2.17 on 2025-02-20 09:51
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        (
+            "klantinteracties",
+            "0027_alter_betrokkene_bezoekadres_nummeraanduiding_id_and_more",
+        ),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="partijidentificator",
+            name="sub_identificator_van",
+            field=models.ForeignKey(
+                blank=True,
+                help_text="Expresses that one PartijIdentificator is bound to another one",
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="parent_partij_identificator",
+                to="klantinteracties.partijidentificator",
+                verbose_name="sub identificator van",
+            ),
+        ),
+    ]

src/openklant/components/klantinteracties/migrations/0028_partijidentificator_sub_identificator_van.py

@@ -414,36 +414,6 @@ class PartijIdentificator(models.Model):
     class Meta:
         verbose_name = _("partij identificator")
         verbose_name_plural = _("partij identificatoren")
-        constraints = [
-            # TODO: cahnge msg
-            models.UniqueConstraint(
-                fields=[
-                    "sub_identificator_van",
-                    "partij_identificator_code_objecttype",
-                    "partij_identificator_code_soort_object_id",
-                    "partij_identificator_object_id",
-                    "partij_identificator_code_register",
-                ],
-                condition=models.Q(sub_identificator_van__isnull=False),
-                name="scoped_identificator_globally_unique",
-            ),
-            # TODO: cahnge msg
-            models.UniqueConstraint(
-                fields=[
-                    "partij_identificator_code_objecttype",
-                    "partij_identificator_code_soort_object_id",
-                    "partij_identificator_object_id",
-                    "partij_identificator_code_register",
-                ],
-                name="non_scoped_identificator_globally_unique",
-                condition=models.Q(sub_identificator_van__isnull=True),
-            ),
-            # TODO: cahnge msg
-            models.CheckConstraint(
-                check=~models.Q(sub_identificator_van=models.F("id")),
-                name="check_sub_identificator_van_not_self",
-            ),
-        ]
 
     def __str__(self):
         soort_object = self.partij_identificator_code_soort_object_id

src/openklant/components/klantinteracties/migrations/0028_partijidentificator_sub_identificator_van_and_more.py

@@ -27,6 +27,7 @@ def __init__(self, queryset, partij_identificator, sub_identificator_van, instan
     def check(self):
         self.check_self_relation()
         self.check_sub_identificator_van()
+        self.check_identificator_partij_unique()
         self.check_identificator_globally_unique()
 
     def check_self_relation(self):
@@ -92,6 +93,17 @@ def check_sub_identificator_van(self):
                     }
                 )
 
+    def check_identificator_partij_unique(self):
+        return
+        if self.queryset.filter(**filters).exists():
+            raise ValidationError(
+                {
+                    "__all__": _(
+                        "`PartijIdentificator` moet uniek zijn, er bestaat er al een met deze gegevenscombinatie."
+                    )
+                }
+            )
+
     def check_identificator_globally_unique(self):
         """
         Checks models constraints
@@ -168,10 +180,10 @@ class PartijIdentificatorTypesValidator:
 
     def __init__(self, partij_identificator: dict) -> None:
         """Initialize validator"""
-        self.code_register = partij_identificator.get("code_register", "")
-        self.code_objecttype = partij_identificator.get("code_objecttype", "")
-        self.code_soort_object_id = partij_identificator.get("code_soort_object_id", "")
-        self.object_id = partij_identificator.get("object_id", "")
+        self.code_register = partij_identificator["code_register"]
+        self.code_objecttype = partij_identificator["code_objecttype"]
+        self.code_soort_object_id = partij_identificator["code_soort_object_id"]
+        self.object_id = partij_identificator["object_id"]
 
     def validate(self) -> None:
         """Run all validations"""