Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possibility to record "overige" PartijIdentificatoren #351

Open
swrichards opened this issue Mar 3, 2025 · 0 comments
Open

Remove possibility to record "overige" PartijIdentificatoren #351

swrichards opened this issue Mar 3, 2025 · 0 comments
Assignees
Labels
discuss enhancement New feature or request triage
Milestone

Comments

@swrichards
Copy link
Contributor

swrichards commented Mar 3, 2025

In the current API spec it is not effectively possible to record "overige" (i.e. non-formal, such as bsn or kvk) identificatoren. This is for two reasons:

  1. The various enums for register, object type, etc. contain an 'overig' option, but this is incomplete: you have no good place to specify what kind of overig object it is (except possibly in the anderePartijIdentificator field, but that does not seem very consistent)
  2. Now that the various meta-attributes are unique together, you can also only add a single "overig" identifier (for a given identifier value).

This means that, currently, "overige" identificatoren are broken. We need a better solution for this, but we also do not want to delay the release of 2.6.0 for this. The proposal here is therefore to:

  1. Remove 'overig' from all the identificator enums
  2. Remove the field anderePartijIdentificator
  3. Make partijIdentificator non-nullable in the serializer

So that the current object is at least coherent and consistent for the "formal" registrations. We will then re-introduce a mechanism for overige identificatoren after we agree on a proposal with the various stakeholders. This is preferable to a release in which overige identificatoren are effectively broken.

Current API spec:
Image

@stevenbal stevenbal added this to the Release 2.6.0 milestone Mar 3, 2025
@stevenbal stevenbal added bug Something isn't working triage labels Mar 3, 2025
@stevenbal stevenbal changed the title Remove possibility to record "overige" identificatoren Remove possibility to record "overige" PartijIdentificatoren Mar 3, 2025
@joeribekker joeribekker added enhancement New feature or request discuss and removed bug Something isn't working labels Mar 3, 2025
@danielmursa-dev danielmursa-dev self-assigned this Mar 3, 2025
@danielmursa-dev danielmursa-dev moved this from Triage to Todo in Data en API fundament Mar 3, 2025
@stevenbal stevenbal moved this from Todo to Triage in Data en API fundament Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New feature or request triage
Projects
Status: Triage
Development

No branches or pull requests

4 participants