Replace libjansson dependency with jq program

[Pri-yan-shu]

Currenly the program depends on libjansson for parsing bear intercept output.

Proposed changes

Remove libjansson dependency and related code.
Create a new script which calls bear intercept and extract package names in a new file, each package on one line. Instead of calling bear intercept directly, we call this script, and then read package names from our new file.

Instead of requiring libjansson development package, systems would require the jq program.

Notes:

The functionality of virt-pack -- build_command and virt-pack --remove must remain unchanged when no name is supplied, to ensure compatibility with existing workflows.
Make sure to test using the directories in the code-base.

[mdrokz]

Currenly the program depends on libjansson for parsing bear intercept output.

Proposed changes

Remove libjansson dependency and related code. Create a new script which calls bear intercept and extract package names in a new file, each package on one line. Instead of calling bear intercept directly, we call this script, and then read package names from our new file.

Instead of requiring libjansson development package, systems would require the jq program.

Notes:

The functionality of virt-pack -- build_command and virt-pack --remove must remain unchanged when no name is supplied, to ensure compatibility with existing workflows. Make sure to test using the directories in the code-base.

Hello, i would like to contribute on this issue, can i take it up ?

[MS-githubaccnt]

Great @mdrokz ! Take a look around at the codebase, and please go ahead and explain the approach you would take for the issue.

[mdrokz]

Great @mdrokz ! Take a look around at the codebase, and please go ahead and explain the approach you would take for the issue.

I took a look at the codebase and ran the project, here is the approach im thinking of taking i dont have much experience with C so please correct me if im wrong

1. create a new script to call bear-intercept and pipe the output to jq to parse the events
2. remove the existing code in make.c and call the new script
3. take output of the script and pass it to the install script

is this correct ?

[Pri-yan-shu]

Yeah it seems correct. Store the extracted libraries in a plaintext file in same directory, and instead of parse_libs() reading events.json we can read the libraries directly from the install script. That would increase the logic in install script but help in case of very large number of libraries, since currently we use a fixed size buffer for library names. Feel free to ask any doubt regarding this, or to get feedback on code changes.

[mdrokz]

Yeah it seems correct. Store the extracted libraries in a plaintext file in same directory, and instead of parse_libs() reading events.json we can read the libraries directly from the install script. That would increase the logic in install script but help in case of very large number of libraries, since currently we use a fixed size buffer for library names. Feel free to ask any doubt regarding this, or to get feedback on code changes.

Got it thanks, if i get stuck i will reach out