-
Notifications
You must be signed in to change notification settings - Fork 21
fix(playground): overlay run button for shared playground #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation, I think the design could be a little better - could we use the same icon we use in the top nav next to the playground link, obviously a little bigger, so it's almost like a video play icon overlay?
c0bf2cf to
9149452
Compare
Done. Used the
Made the size bigger and responsive.
We play videos and run code so shouldn't it be called "MDN Runground"? 🤔 playRun.mp4 |
|
Let me... "Run" this past our content team and see what they think |
|
I could imagine making the button smaller, and adding some sort of warning below, so that the user understands the risks of pressing run. |
"Risk of pressing run", we don't want to scare users so much that they won't even run the code. We already have report banner at the top, how about we reword it like the following? |

Description
Need a prominent Run button on canvas for shared playgrounds because the shared code could be untrustworthy.
Motivation
In the current state it is not apparent that users are supposed to click run button to get the output and begin autorun for the shared playgrounds.
It was requested to have big button spanning the entire canvas.
Additional details
For testing used this link: http://localhost:3000/en-US/play?id=rCfusnHbQaseoVnpt5%2BOn3b12l6jKOf8oDyb9smSb5ueTnvaFpg87%2FSZ4fWjiysCSJBwRrmdXiMXJnTQ
After changes UI:
runButton.mp4
Related issues and pull requests
#665