Skip to content

Commit d2c7c18

Browse files
committed
hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
Looking at the MV64341 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus somehow? */ 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) { 526 ret = pic_read_irq(isa_pic); 527 } 528 break; Add it to Kconfig to avoid the following build failure: /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361_read': hw/pci-host/mv64361.c:526: undefined reference to `isa_pic' /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_irq' Fixes: dcdf98a ("hw/pci-host: Add emulation of Marvell MV64361 PPC system controller") Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: BALATON Zoltan <[email protected]> Reviewed-by: Bin Meng <[email protected]> Acked-by: David Gibson <[email protected]> Message-Id: <[email protected]>
1 parent ed2543a commit d2c7c18

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

hw/pci-host/Kconfig

+1
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,4 @@ config SH_PCI
7676
config MV64361
7777
bool
7878
select PCI
79+
select I8259

0 commit comments

Comments
 (0)