chore: eslint fixes

Author: mdvorak

.github/workflows/build.yml

@@ -37,8 +37,8 @@ jobs:
 
       - name: Test
         run: |-
-          npm run test:ci
           npm run build
+          npm run test:ci
 
       # Publish
       - name: Publish

package.json

@@ -9,6 +9,7 @@
     "build": "tsc --project tsconfig.build.json",
     "test": "jest --config jest.config.ts --coverage",
     "test:ci": "npm run lint && npm run test -- --no-cache",
+    "all": "npm run lint && npm run build && npm run test",
     "prepack": "npm run build"
   },
   "repository": {

src/properties.spec.ts

@@ -1,10 +1,12 @@
 import * as fs from 'node:fs/promises'
+
 import properties from '.'
 
 describe('parse', () => {
   it('should parse all lines', () => {
     // Data
-    const sample = 'registry=https://abcd\n#foo bar\r\n@scope:test=avx\rextra\r\n'
+    const sample =
+      'registry=https://abcd\n#foo bar\r\n@scope:test=avx\rextra\r\n'
 
     // Test
     const result = properties.parse(sample)
@@ -108,21 +110,17 @@ describe('data access', () => {
       expect(result).toBe(expected)
     })
 
-    it.each([
-      ['foo6'],
-      ['foo7']
-    ])('should not get commented property "%s"', (key) => {
-      const result = properties.get(sample, key)
-      expect(result).toBeUndefined()
-    })
+    it.each([['foo6'], ['foo7']])(
+      'should not get commented property "%s"',
+      key => {
+        const result = properties.get(sample, key)
+        expect(result).toBeUndefined()
+      }
+    )
 
     it('should return last value of duplicate key', () => {
       const config: properties.Properties = {
-        lines: [
-          'key1=foo1',
-          'key2=foo2',
-          'key1=foo3'
-        ]
+        lines: ['key1=foo1', 'key2=foo2', 'key1=foo3']
       }
 
       const result = properties.get(config, 'key1')
@@ -137,16 +135,16 @@ describe('data access', () => {
       expect(() => properties.get(config, 'foo')).toThrowError()
     })
 
-    it.each([
-      ['foo=bar\\u23a'],
-      ['foo=bar\\u23ax5']
-    ])('should throw on invalid unicode sequence in value %s', (line) => {
-      const config: properties.Properties = {
-        lines: [line]
-      }
+    it.each([['foo=bar\\u23a'], ['foo=bar\\u23ax5']])(
+      'should throw on invalid unicode sequence in value %s',
+      line => {
+        const config: properties.Properties = {
+          lines: [line]
+        }
 
-      expect(() => properties.get(config, 'foo')).toThrowError()
-    })
+        expect(() => properties.get(config, 'foo')).toThrowError()
+      }
+    )
 
     it.each([
       ['foo=bar', 'bar'],
@@ -259,33 +257,20 @@ describe('data access', () => {
 
     it('should use custom separator', () => {
       const config: properties.Properties = {
-        lines: [
-          'key1=foo1',
-          'key2=foo2'
-        ]
+        lines: ['key1=foo1', 'key2=foo2']
       }
 
       properties.set(config, 'key1', 'test', {separator: ': '})
-      expect(config.lines).toEqual([
-        'key1: test',
-        'key2=foo2'
-      ])
+      expect(config.lines).toEqual(['key1: test', 'key2=foo2'])
     })
 
     it('should remove duplicate keys on set', () => {
       const config: properties.Properties = {
-        lines: [
-          'key1=foo1',
-          'key2=foo2',
-          'key1=foo3'
-        ]
+        lines: ['key1=foo1', 'key2=foo2', 'key1=foo3']
       }
 
       properties.set(config, 'key1', 'test')
-      expect(config.lines).toEqual([
-        'key1=test',
-        'key2=foo2'
-      ])
+      expect(config.lines).toEqual(['key1=test', 'key2=foo2'])
     })
   })
 
@@ -308,11 +293,7 @@ describe('data access', () => {
 
     it('should remove all duplicate keys with remove', () => {
       const config: properties.Properties = {
-        lines: [
-          'key1=foo1',
-          'key2=foo2',
-          'key1=foo3'
-        ]
+        lines: ['key1=foo1', 'key2=foo2', 'key1=foo3']
       }
 
       properties.remove(config, 'key1')
@@ -381,7 +362,10 @@ describe('data access', () => {
     })
 
     it('should parse test file', async () => {
-      const contents = await fs.readFile(require.resolve('../fixtures/test-all.properties'), 'utf-8')
+      const contents = await fs.readFile(
+        require.resolve('../fixtures/test-all.properties'),
+        'utf-8'
+      )
 
       // Parse
       const result = properties.toObject(properties.parse(contents))
@@ -397,19 +381,22 @@ describe('data access', () => {
         'evenLikeThis\\': '',
         hello: 'hello',
         helloInJapanese: 'こんにちは',
-        'こんにちは': 'hello',
+        こんにちは: 'hello',
         keyWithBackslashes: 'This has random backslashes',
-        'keyWithDelimiters:= ': 'This is the value for the key "keyWithDelimiters:= "',
+        'keyWithDelimiters:= ':
+          'This is the value for the key "keyWithDelimiters:= "',
         'keyWitheven\\': 'this colon is not escaped',
         language: 'English',
         multiline: 'This line continues on 3 lines',
         multilineKey: 'this is a multiline key',
-        noWhiteSpace: 'The key will be "noWhiteSpace" without any whitespace.    ',
+        noWhiteSpace:
+          'The key will be "noWhiteSpace" without any whitespace.    ',
         oddKey: 'This is line one and\\# This is line two',
         orLikeThis: '',
         path: 'c:\\wiki\\templates',
         topic: '.properties file',
-        valueWithEscapes: 'This is a newline\n, a carriage return\r, a tab\t and a formfeed\f.',
+        valueWithEscapes:
+          'This is a newline\n, a carriage return\r, a tab\t and a formfeed\f.',
         website: 'https://en.wikipedia.org/',
         welcome: 'Welcome to Wikipedia!    '
       })

src/properties.ts

@@ -199,7 +199,7 @@ export const remove = (config: Properties, key: string): void =>
  *
  * @param lines Lines to iterate over.
  */
-function* chars(lines: string[]): Generator<{char: string, line: number}> {
+function* chars(lines: string[]): Generator<{char: string; line: number}> {
   for (let i = 0; i < lines.length; i++) {
     const line = lines[i]
     for (const char of line) {
@@ -225,16 +225,23 @@ function* listPairs(lines: string[]): Generator<{
   value: string
 }> {
   const newState = (): {
-    state: State,
-    start: number,
-    key: string,
-    sep: string,
-    value: string,
-    skipSpace: boolean,
-    escapedNext: boolean,
+    state: State
+    start: number
+    key: string
+    sep: string
+    value: string
+    skipSpace: boolean
+    escapedNext: boolean
     unicode?: string
-  } =>
-    ({state: State.START, start: -1, key: '', sep: '', value: '', skipSpace: true, escapedNext: false})
+  } => ({
+    state: State.START,
+    start: -1,
+    key: '',
+    sep: '',
+    value: '',
+    skipSpace: true,
+    escapedNext: false
+  })
 
   let state = newState()
 
@@ -455,7 +462,10 @@ const parseUnicode = (sequence: string, line: number): string => {
  * @param escapeUnicode Escape unicode chars (below 0x0020 and above 0x007e). Default is true.
  * @return Escaped string.
  */
-export const escapeKey = (unescapedKey: string, escapeUnicode = true): string => {
+export const escapeKey = (
+  unescapedKey: string,
+  escapeUnicode = true
+): string => {
   return escape(unescapedKey, true, escapeUnicode)
 }
 
@@ -466,7 +476,10 @@ export const escapeKey = (unescapedKey: string, escapeUnicode = true): string =>
  * @param escapeUnicode Escape unicode chars (below 0x0020 and above 0x007e). Default is true.
  * @return Escaped string.
  */
-export const escapeValue = (unescapedValue: string, escapeUnicode = true): string => {
+export const escapeValue = (
+  unescapedValue: string,
+  escapeUnicode = true
+): string => {
   return escape(unescapedValue, false, escapeUnicode)
 }
 
@@ -485,7 +498,6 @@ const escape = (
 ): string => {
   const result: string[] = []
 
-  // eslint-disable-next-line unicorn/no-for-loop
   for (let index = 0; index < unescapedContent.length; index++) {
     const char = unescapedContent[index]
     switch (char) {