Skip to content

lack of support for showRankingScoreDetails #1394

@hervenivon

Description

@hervenivon

Description
The library doesn't pass the showRankingScoreDetails to the final request. Only showRankingScore is supported. (documentation)

Expected behavior
I expect the client to pass this parameter to the final request

Current behavior
Only the showRankingScore parameter is passed.

Working
Lib patch that makes it work.

diff --git a/node_modules/@meilisearch/instant-meilisearch/dist/esm/adapter/search-request-adapter/search-params-adapter.js b/node_modules/@meilisearch/instant-meilisearch/dist/esm/adapter/search-request-adapter/search-params-adapter.js
index e91bdd8..52d6101 100644
--- a/node_modules/@meilisearch/instant-meilisearch/dist/esm/adapter/search-request-adapter/search-params-adapter.js
+++ b/node_modules/@meilisearch/instant-meilisearch/dist/esm/adapter/search-request-adapter/search-params-adapter.js
@@ -161,6 +161,12 @@ export function MeiliParamsCreator(searchContext) {
                 meiliSearchParams.showRankingScore = value;
             }
         },
+        addShowRankingScoreDetails() {
+            const value = overrideParams?.showRankingScoreDetails;
+            if (value !== undefined) {
+                meiliSearchParams.showRankingScoreDetails = value;
+            }
+        },
         addAttributesToSearchOn() {
             const value = overrideParams?.attributesToSearchOn !== undefined
                 ? overrideParams.attributesToSearchOn
@@ -220,6 +226,7 @@ export function adaptSearchParams(searchContext) {
     meilisearchParams.addShowMatchesPosition();
     meilisearchParams.addMatchingStrategy();
     meilisearchParams.addShowRankingScore();
+    meilisearchParams.addShowRankingScoreDetails();
     meilisearchParams.addAttributesToSearchOn();
     meilisearchParams.addHybridSearch();
     meilisearchParams.addVector();
diff --git a/node_modules/@meilisearch/instant-meilisearch/dist/esm/cache/init-facets-distribution.js b/node_modules/@meilisearch/instant-meilisearch/dist/esm/cache/init-facets-distribution.js
index 9c6b91e..3ef0b37 100644
--- a/node_modules/@meilisearch/instant-meilisearch/dist/esm/cache/init-facets-distribution.js
+++ b/node_modules/@meilisearch/instant-meilisearch/dist/esm/cache/init-facets-distribution.js
@@ -18,12 +18,7 @@ export function getParametersWithoutFilters(searchContext) {
 // Used to fill the missing facet values when `keepZeroFacets` is set to true
 export async function initFacetDistribution(searchResolver, queries, initialFacetDistribution) {
     const removeIndexUidDuplicates = removeDuplicate('indexUid');
-    const searchQueries = queries
-        .filter(removeIndexUidDuplicates) // only make one request per indexUid
-        .filter(({ indexUid }) => {
-        // avoid requesting on indexes that already have an initial facetDistribution
-        return !Object.keys(initialFacetDistribution).includes(indexUid);
-    });
+    const searchQueries = [];
     if (searchQueries.length === 0)
         return initialFacetDistribution;
     const results = await searchResolver.multiSearch(searchQueries, []);
diff --git a/node_modules/@meilisearch/instant-meilisearch/dist/types/adapter/search-request-adapter/search-params-adapter.d.ts b/node_modules/@meilisearch/instant-meilisearch/dist/types/adapter/search-request-adapter/search-params-adapter.d.ts
index bc8e644..e86ced9 100644
--- a/node_modules/@meilisearch/instant-meilisearch/dist/types/adapter/search-request-adapter/search-params-adapter.d.ts
+++ b/node_modules/@meilisearch/instant-meilisearch/dist/types/adapter/search-request-adapter/search-params-adapter.d.ts
@@ -23,6 +23,7 @@ export declare function MeiliParamsCreator(searchContext: SearchContext): {
     addShowMatchesPosition(): void;
     addMatchingStrategy(): void;
     addShowRankingScore(): void;
+    addShowRankingScoreDetails(): void;
     addAttributesToSearchOn(): void;
     addHybridSearch(): void;
     addVector(): void;

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions