Skip to content

[v1.13] Add embbedings database metrics to stats #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Strift opened this issue Feb 20, 2025 · 2 comments · Fixed by #1888
Closed
2 tasks

[v1.13] Add embbedings database metrics to stats #1874

Strift opened this issue Feb 20, 2025 · 2 comments · Fixed by #1888
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Strift
Copy link
Collaborator

Strift commented Feb 20, 2025

Following the changes related to Meilisearch v1.13.0 mega issue:

Description

Update the stats object to include the new embbedings database metrics.

For further reference, see the related Meilisearch engine issue.

Specifications

  • Modify the stats API to include indexes.INDEXNAME.numberOfEmbeddedDocuments in SDK responses
  • Modify the stats API to include indexes.INDEXNAME.numberOfEmbeddings in SDK responses
@Strift Strift added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2025
@consoleLogIt
Copy link
Contributor

consoleLogIt commented Feb 26, 2025 •
edited
Loading

@Strift
Hi i would like to work on this, could you please provide some more info on this?
From what I understand, we need to update the IndexStats type and the tests for the getStatus api ??
thanks

@Strift
Copy link
Collaborator Author

Strift commented Feb 27, 2025

Hi @consoleLogIt, thanks for your interest!

Yes. That would also most likely involve updating the snapshots of the tests :)

Looking forward to your PR 🙌

@consoleLogIt consoleLogIt mentioned this issue Mar 1, 2025
Merged
5 tasks
@meili-bors meili-bors bot closed this as completed in f006930 Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add embedding metrics consoleLogIt/meilisearch-js
2 participants
@Strift @consoleLogIt