Merge #259

259: Add timeoutSeconds to probes in values.yaml and statefulset.yaml r=brunoocasali a=lukdz

# Pull Request

## Related issue
[Allow full customisation of probes #233](#233)

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: lukdz <[email protected]>
Co-authored-by: brunoocasali <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>

Author: 3 people

charts/meilisearch/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "v1.16.0"
 description: A Helm chart for the Meilisearch search engine
 name: meilisearch
-version: 0.15.0
+version: 0.15.1
 icon: https://raw.githubusercontent.com/meilisearch/integration-guides/main/assets/logos/logo.svg
 home: https://github.com/meilisearch/meilisearch-kubernetes/tree/main/charts/meilisearch
 maintainers:

charts/meilisearch/README.md

@@ -76,6 +76,7 @@ You can also use `auth.existingMasterKeySecret` to use an existing secret that h
 | ingress.tls | list | `[]` | TLS specification |
 | livenessProbe.InitialDelaySeconds | int | `0` |  |
 | livenessProbe.periodSeconds | int | `10` |  |
+| livenessProbe.timeoutSeconds | int | `10` |  |
 | nameOverride | string | `""` | String to partially override meilisearch.fullname |
 | nodeSelector | object | `{}` | Node labels for pod assignment |
 | persistence.accessMode | string | `"ReadWriteOnce"` | PVC Access Mode |
@@ -95,6 +96,7 @@ You can also use `auth.existingMasterKeySecret` to use an existing secret that h
 | podSecurityContext.runAsUser | int | `1000` |  |
 | readinessProbe.InitialDelaySeconds | int | `0` |  |
 | readinessProbe.periodSeconds | int | `10` |  |
+| readinessProbe.timeoutSeconds | int | `10` |  |
 | replicaCount | int | `1` | Number of Meilisearch pods to run |
 | resources | object | `{}` | Resources allocation (Requests and Limits) |
 | securityContext.allowPrivilegeEscalation | bool | `false` |  |
@@ -118,6 +120,7 @@ You can also use `auth.existingMasterKeySecret` to use an existing secret that h
 | startupProbe.InitialDelaySeconds | int | `1` |  |
 | startupProbe.failureThreshold | int | `60` |  |
 | startupProbe.periodSeconds | int | `1` |  |
+| startupProbe.timeoutSeconds | int | `1` |  |
 | tolerations | list | `[]` | Tolerations for pod assignment |
 | volumeMounts | list | `[]` | Additional volumes to mount on pod |
 | volumes | list | `[]` | Additional volumes for pod |

charts/meilisearch/templates/statefulset.yaml

@@ -94,18 +94,21 @@ spec:
             periodSeconds: {{ .Values.startupProbe.periodSeconds }}
             initialDelaySeconds: {{ .Values.startupProbe.InitialDelaySeconds }}
             failureThreshold: {{ .Values.startupProbe.failureThreshold }}
+            timeoutSeconds: {{ .Values.startupProbe.timeoutSeconds }}
           livenessProbe:
             httpGet:
               path: /health
               port: http
             periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
             initialDelaySeconds: {{ .Values.livenessProbe.InitialDelaySeconds }}
+            timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
           readinessProbe:
             httpGet:
               path: /health
               port: http
             periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
             initialDelaySeconds: {{ .Values.readinessProbe.InitialDelaySeconds }}
+            timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
           resources:
 {{ toYaml .Values.resources | indent 12 }}
       {{- if .Values.containers }}

charts/meilisearch/values.yaml

@@ -6,14 +6,17 @@ startupProbe:
   periodSeconds: 1
   InitialDelaySeconds: 1
   failureThreshold: 60
+  timeoutSeconds: 1
 
 readinessProbe:
   periodSeconds: 10
   InitialDelaySeconds: 0
+  timeoutSeconds: 10
 
 livenessProbe:
   periodSeconds: 10
   InitialDelaySeconds: 0
+  timeoutSeconds: 10
 
 image:
   # -- Meilisearch image name

manifests/meilisearch.yaml

@@ -75,7 +75,7 @@ spec:
         app.kubernetes.io/component: search-engine
         app.kubernetes.io/part-of: meilisearch
       annotations:
-        checksum/config: 99f5ed2d93e472f0e548cad1d77278ea3fe2d8837f911ab7a999958f71bbc945
+        checksum/config: 3475180c39b5741fb0c3f07283ca79ec3d6666080733103b501c9f6b31111c4e
     spec:
       serviceAccountName: meilisearch
       securityContext:
@@ -121,18 +121,21 @@ spec:
             periodSeconds: 1
             initialDelaySeconds: 1
             failureThreshold: 60
+            timeoutSeconds: 1
           livenessProbe:
             httpGet:
               path: /health
               port: http
             periodSeconds: 10
             initialDelaySeconds: 0
+            timeoutSeconds: 10
           readinessProbe:
             httpGet:
               path: /health
               port: http
             periodSeconds: 10
             initialDelaySeconds: 0
+            timeoutSeconds: 10
           resources:
             {}
 ---