Merge #120

120: Type flexibility improvements r=curquiza a=Mubelotix

[Rust 1.51 is stable!](https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html)
That allows us to build much more powerful traits using const generics so that this library can handle a huge number of types!

Co-authored-by: Mubelotix <[email protected]>

Author: bors[bot]

.code-samples.meilisearch.yaml

@@ -73,7 +73,7 @@ update_settings_1: |-
   synonyms.insert(String::from("logan"), vec!["wolverine"]);
 
   let settings = Settings::new()
-    .with_ranking_rules(&[
+    .with_ranking_rules([
       "typo",
       "words",
       "proximity",
@@ -82,24 +82,24 @@ update_settings_1: |-
       "exactness",
       "desc(release_date)",
       "desc(rank)"
-    ][..])
+    ])
     .with_distinct_attribute("movie_id")
-    .with_searchable_attributes(&[
+    .with_searchable_attributes([
       "title",
       "description",
       "genre"
-    ][..])
-    .with_displayed_attributes(&[
+    ])
+    .with_displayed_attributes([
       "title",
       "description",
       "genre",
       "release_date"
-    ][..])
-    .with_stop_words(&[
+    ])
+    .with_stop_words([
       "the",
       "a",
       "an"
-    ][..])
+    ])
     .with_synonyms(synonyms);
 
   let progress: Progress = movies.set_settings(&settings).await.unwrap();
@@ -120,7 +120,7 @@ get_stop_words_1: |-
   let stop_words: Vec<String> = movies.get_stop_words().await.unwrap();
 update_stop_words_1: |-
   let stop_words = ["of", "the", "to"];
-  let progress: Progress = movies.set_stop_words(&stop_words[..]).await.unwrap();
+  let progress: Progress = movies.set_stop_words(&stop_words).await.unwrap();
 reset_stop_words_1: |-
   let progress: Progress = movies.reset_stop_words().await.unwrap();
 get_ranking_rules_1: |-
@@ -137,7 +137,7 @@ update_ranking_rules_1: |-
     "desc(rank)",
   ];
 
-  let progress: Progress = movies.set_ranking_rules(&ranking_rules[..]).await.unwrap();
+  let progress: Progress = movies.set_ranking_rules(&ranking_rules).await.unwrap();
 reset_ranking_rules_1: |-
   let progress: Progress = movies.reset_ranking_rules().await.unwrap();
 get_distinct_attribute_1: |-
@@ -155,7 +155,7 @@ update_searchable_attributes_1: |-
     "genre"
   ];
 
-  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes).await.unwrap();
 reset_searchable_attributes_1: |-
   let progress: Progress = movies.reset_searchable_attributes().await.unwrap();
 get_attributes_for_faceting_1: |-
@@ -166,7 +166,7 @@ update_attributes_for_faceting_1: |-
     "director"
   ];
 
-  let progress: Progress = movies.set_attributes_for_faceting(&attributes_for_faceting[..]).await.unwrap();
+  let progress: Progress = movies.set_attributes_for_faceting(&attributes_for_faceting).await.unwrap();
 reset_attributes_for_faceting_1: |-
   let progress: Progress = movies.reset_attributes_for_faceting().await.unwrap();
 get_displayed_attributes_1: |-
@@ -179,7 +179,7 @@ update_displayed_attributes_1: |-
     "release_date"
   ];
 
-  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes).await.unwrap();
 reset_displayed_attributes_1: |-
   let progress: Progress = movies.reset_displayed_attributes().await.unwrap();
 get_index_stats_1: |-
@@ -201,7 +201,7 @@ field_properties_guide_searchable_1: |-
     "genre"
   ];
 
-  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes).await.unwrap();
 field_properties_guide_displayed_1: |-
   let displayed_attributes = [
     "title",
@@ -210,7 +210,7 @@ field_properties_guide_displayed_1: |-
     "release_date"
   ];
 
-  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes).await.unwrap();
 filtering_guide_1: |-
   let results: SearchResults<Movie> = movies.search()
     .with_query("Avengers")
@@ -321,9 +321,9 @@ settings_guide_synonyms_1: |-
   let tops: Index = client.get_index("tops").await.unwrap();
   let progress: Progress = tops.set_synonyms(&synonyms).await.unwrap();
 settings_guide_stop_words_1: |-
-  let progress: Progress = movies.set_stop_words(&["the", "a", "an"][..]).await.unwrap();
+  let progress: Progress = movies.set_stop_words(["the", "a", "an"]).await.unwrap();
 settings_guide_attributes_for_faceting_1: |-
-  let progress: Progress = movies.set_attributes_for_faceting(&["director", "genres"][..]).await.unwrap();
+  let progress: Progress = movies.set_attributes_for_faceting(["director", "genres"]).await.unwrap();
 settings_guide_ranking_rules_1: |-
   let ranking_rules = [
     "typo",
@@ -336,7 +336,7 @@ settings_guide_ranking_rules_1: |-
     "desc(rank)",
   ];
 
-  let progress: Progress = movies.set_ranking_rules(&ranking_rules[..]).await.unwrap();
+  let progress: Progress = movies.set_ranking_rules(&ranking_rules).await.unwrap();
 settings_guide_distinct_1: |-
   let jackets: Index = client.get_index("jackets").await.unwrap();
   let progress: Progress = jackets.set_distinct_attribute("product_id").await.unwrap();
@@ -347,7 +347,7 @@ settings_guide_searchable_1: |-
     "genre"
   ];
 
-  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_searchable_attributes(&searchable_attributes).await.unwrap();
 settings_guide_displayed_1: |-
   let displayed_attributes = [
     "title",
@@ -356,7 +356,7 @@ settings_guide_displayed_1: |-
     "release_date"
   ];
 
-  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes[..]).await.unwrap();
+  let progress: Progress = movies.set_displayed_attributes(&displayed_attributes).await.unwrap();
 documents_guide_add_movie_1: |-
   // Define the type of our documents
   #[derive(Serialize, Deserialize, Debug)]
@@ -500,7 +500,7 @@ getting_started_search_md: |-
 
   [About this SDK](https://github.com/meilisearch/meilisearch-rust/)
 faceted_search_update_settings_1: |-
-  let progress: Progress = movies.set_attributes_for_faceting(&["director", "genres"][..]).await.unwrap();
+  let progress: Progress = movies.set_attributes_for_faceting(["director", "genres"]).await.unwrap();
 faceted_search_facet_filters_1: |-
   let results: SearchResults<Movie> = movies.search()
     .with_query("thriller")
@@ -524,7 +524,7 @@ faceted_search_walkthrough_attributes_for_faceting_1: |-
     "production_companies"
   ];
 
-  let progress: Progress = movies.set_attributes_for_faceting(&attributes_for_faceting[..]).await.unwrap();
+  let progress: Progress = movies.set_attributes_for_faceting(&attributes_for_faceting).await.unwrap();
 faceted_search_walkthrough_facet_filters_1: |-
   let results: SearchResults<Movie> = movies.search()
     .with_query("thriller")

src/indexes.rs

@@ -661,7 +661,7 @@ impl<'a> Index<'a> {
     /// # sleep(Duration::from_secs(1));
     /// 
     /// let status = movies.get_all_updates().await.unwrap();
-    /// assert_eq!(status.len(), 2);
+    /// assert!(status.len() >= 2);
     /// # client.delete_index("movies_get_all_updates").await.unwrap();
     /// # });
     /// ```

src/progress.rs

@@ -262,7 +262,7 @@ mod test {
     #[async_test]
     async fn test_wait_for_pending_updates_with_args() {
         let client = Client::new("http://localhost:7700", "masterKey");
-        let movies = client.create_index("movies_wait_for_pending_args", None).await.unwrap();
+        let movies = client.get_or_create("movies_wait_for_pending_args").await.unwrap();
         let progress = movies.add_documents(&[
             Document {
                 id: 0,
@@ -286,7 +286,7 @@ mod test {
     #[async_test]
     async fn test_wait_for_pending_updates_time_out() {
         let client = Client::new("http://localhost:7700", "masterKey");
-        let movies = client.create_index("movies_wait_for_pending_timeout", None).await.unwrap();
+        let movies = client.get_or_create("movies_wait_for_pending_timeout").await.unwrap();
         let progress = movies.add_documents(&[
             Document {
                 id: 0,

src/search.rs

@@ -322,7 +322,7 @@ mod tests {
             Document { id: 8, kind: "title".into(), value: "Harry Potter and the Half-Blood Prince".to_string() },
             Document { id: 9, kind: "title".into(), value: "Harry Potter and the Deathly Hallows".to_string() },
         ], None).await.unwrap();
-        index.set_attributes_for_faceting(&["kind"][..]).await.unwrap();
+        index.set_attributes_for_faceting(["kind"]).await.unwrap();
         sleep(Duration::from_secs(1));
         index
     }

src/settings.rs

@@ -10,7 +10,7 @@ use crate::{indexes::Index, errors::Error, request::{request, Method}, progress:
 /// ```
 /// # use meilisearch_sdk::settings::Settings;
 /// let settings = Settings::new()
-///     .with_stop_words(&["a", "the", "of"][..]);
+///     .with_stop_words(["a", "the", "of"]);
 ///
 /// // OR
 ///
@@ -107,9 +107,6 @@ impl IntoVecString for &[&String] {
     }
 }
 
-/*
-TODO: Implement IntoVecString trought const generics as soon as they are stable.
-
 impl<const N: usize> IntoVecString for &[String; N] {
     fn convert(self) -> Vec<String> {
         let mut vec = Vec::new();
@@ -119,7 +116,36 @@ impl<const N: usize> IntoVecString for &[String; N] {
         vec
     }
 }
-*/
+
+impl<const N: usize> IntoVecString for &[&str; N] {
+    fn convert(self) -> Vec<String> {
+        let mut vec = Vec::new();
+        for item in self {
+            vec.push((*item).to_string())
+        }
+        vec
+    }
+}
+
+impl<const N: usize> IntoVecString for [String; N] {
+    fn convert(self) -> Vec<String> {
+        let mut vec = Vec::new();
+        for item in self.iter() {
+            vec.push((*item).clone())
+        }
+        vec
+    }
+}
+
+impl<const N: usize> IntoVecString for [&str; N] {
+    fn convert(self) -> Vec<String> {
+        let mut vec = Vec::new();
+        for item in self.iter() {
+            vec.push((*item).to_string())
+        }
+        vec
+    }
+}
 
 #[allow(missing_docs)]
 impl Settings {
@@ -411,7 +437,7 @@ impl<'a> Index<'a> {
     /// let mut movie_index = client.get_or_create("movies").await.unwrap();
     ///
     /// let stop_words = ["the", "of", "to"];
-    /// let progress = movie_index.set_stop_words(&stop_words[..]).await.unwrap();
+    /// let progress = movie_index.set_stop_words(&stop_words).await.unwrap();
     /// # std::thread::sleep(std::time::Duration::from_secs(2));
     /// # progress.get_status().await.unwrap();
     /// # });
@@ -446,7 +472,7 @@ impl<'a> Index<'a> {
     ///     "asc(release_date)",
     ///     "desc(rank)",
     /// ];
-    /// let progress = movie_index.set_ranking_rules(&ranking_rules[..]).await.unwrap();
+    /// let progress = movie_index.set_ranking_rules(ranking_rules).await.unwrap();
     /// # std::thread::sleep(std::time::Duration::from_secs(2));
     /// # progress.get_status().await.unwrap();
     /// # });
@@ -472,7 +498,7 @@ impl<'a> Index<'a> {
     /// let mut movie_index = client.get_or_create("movies").await.unwrap();
     ///
     /// let attributes_for_faceting = ["genre", "director"];
-    /// let progress = movie_index.set_attributes_for_faceting(&attributes_for_faceting[..]).await.unwrap();
+    /// let progress = movie_index.set_attributes_for_faceting(&attributes_for_faceting).await.unwrap();
     /// # std::thread::sleep(std::time::Duration::from_secs(2));
     /// # progress.get_status().await.unwrap();
     /// # });
@@ -522,7 +548,7 @@ impl<'a> Index<'a> {
     /// let client = Client::new("http://localhost:7700", "masterKey");
     /// let mut movie_index = client.get_or_create("movies").await.unwrap();
     ///
-    /// let progress = movie_index.set_searchable_attributes(&["title", "description", "uid"][..]).await.unwrap();
+    /// let progress = movie_index.set_searchable_attributes(["title", "description", "uid"]).await.unwrap();
     /// # std::thread::sleep(std::time::Duration::from_secs(2));
     /// # progress.get_status().await.unwrap();
     /// # });
@@ -547,7 +573,7 @@ impl<'a> Index<'a> {
     /// let client = Client::new("http://localhost:7700", "masterKey");
     /// let mut movie_index = client.get_or_create("movies").await.unwrap();
     ///
-    /// let progress = movie_index.set_displayed_attributes(&["title", "description", "release_date", "rank", "poster"][..]).await.unwrap();
+    /// let progress = movie_index.set_displayed_attributes(["title", "description", "release_date", "rank", "poster"]).await.unwrap();
     /// # std::thread::sleep(std::time::Duration::from_secs(2));
     /// # progress.get_status().await.unwrap();
     /// # });