Deprecation warnings in Symfony 7.3

[tacman]

I'm testing with Symfony 7.3 beta 2 and seeing these messages. They are relatively easy to fix, rector even has a rule for them, but they only work with PHP 8 because of attributes.

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultName()" in "Meilisearch\Bundle\Command\MeilisearchClearCommand" is deprecated 
and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.


  1x: Since symfony/console 7.3: Overriding "Command::getDefaultDescription()" in "Meilisearch\Bundle\Command\MeilisearchClearCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultName()" in "Meilisearch\Bundle\Command\MeilisearchCreateCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultDescription()" in "Meilisearch\Bundle\Command\MeilisearchCreateCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultName()" in "Meilisearch\Bundle\Command\MeilisearchDeleteCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultDescription()" in "Meilisearch\Bundle\Command\MeilisearchDeleteCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultName()" in "Meilisearch\Bundle\Command\MeilisearchImportCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

  1x: Since symfony/console 7.3: Overriding "Command::getDefaultDescription()" in "Meilisearch\Bundle\Command\MeilisearchImportCommand" is deprecated and will be removed in Symfony 8.0, use the #[AsCommand] attribute instead.
    1x in BaseVisitLinksTest::linksToVisit from Survos\CrawlerBundle\Tests

[norkunas]

They are relatively easy to fix

So send a PR to fix? :)

[norkunas]

but they only work with PHP 8 because of attributes.

Note that #[AsCommand] attribute is just for DX, behind the scenes it still adds console.command tag along with metadata, which is the way to go here to fix the deprecations while maintaining support for < php8

[tacman]

Ah, true, since in PHP 7 it's just a comment.

[tacman]

it's an easy fix for PHP 8 only, but to maintain both 7 and 8 is more work.

What about a new point release, dropping anything that's no longer supported (that is, only support ^6.4||^7.2)?

[norkunas]

@tacman in 99% cases it's possible to support library without dropping support for other dependency versions 😛 as you can see in #382 there was not much that work

[brunoocasali]

Hey folks, what would be the impact of the release of the PHP PR deprecating PHP v7 in the Symfony repo? Lots of changes? Frustrated users? Shame not to have done it before?

[norkunas]

As we are on 0.x releases here, I think BC breaks/dependency bumps are expected.
I'd like to finish data providers before v1, but need more time