Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make create_col consistent for all Vector Stores #2465

Open
Dev-Khant opened this issue Mar 29, 2025 · 3 comments · May be fixed by #2497
Open

Make create_col consistent for all Vector Stores #2465

Dev-Khant opened this issue Mar 29, 2025 · 3 comments · May be fixed by #2497
Assignees
@parshvadaftari

Comments

@Dev-Khant
Copy link
Member

🐛 Describe the bug

Currently, the create_col function in all vector stores has different sets of parameters. To maintain consistency across all vector stores, update the base method to create_col(self) with no parameters. All necessary parameters should be accessed from the __init__ method.
@parshvadaftari
Copy link
Contributor

I can pick this up. Can you assign me?

@Dev-Khant
Copy link
Member Author

Hey @parshvadaftari Feel free to work on it.

@parshvadaftari parshvadaftari linked a pull request Apr 2, 2025 that will close this issue
Open
15 tasks
@parshvadaftari
Copy link
Contributor

Hey @Dev-Khant I've raised the PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parshvadaftari parshvadaftari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistent create_col for the vectorstores parshvadaftari/mem0
2 participants
@Dev-Khant @parshvadaftari