Skip to content

Commit d07a931

Browse files
committed
fix(dashboard): add key to panel menu items
1 parent 4af6697 commit d07a931

File tree

3 files changed

+22
-18
lines changed

3 files changed

+22
-18
lines changed

dashboard/src/components/panel/panel-editor/dropdown-menu-items/use-items.tsx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,56 +32,56 @@ export const useItems = (view: ViewMetaInstance) => {
3232
const ret: PanelMenuItem[] = [
3333
{
3434
order: 10,
35-
render: () => <Refresh />,
35+
render: () => <Refresh key="refresh" />,
3636
},
3737
{
3838
order: 100,
39-
render: () => <DownloadData />,
39+
render: () => <DownloadData key="download-data" />,
4040
},
4141
{
4242
order: 200,
43-
render: () => <DownloadSchema />,
43+
render: () => <DownloadSchema key="download-schema" />,
4444
},
4545
{
4646
order: 300,
47-
render: () => <DownloadScreenshot />,
47+
render: () => <DownloadScreenshot key="download-screenshot" />,
4848
},
4949
{
5050
order: 400,
51-
render: () => <EnterFullScreen view={view} />,
51+
render: () => <EnterFullScreen key="enter-full-screen" view={view} />,
5252
},
5353
...queryItems,
5454
{
5555
order: 600,
56-
render: () => <Divider label={t('common.actions.edit')} labelPosition="center" />,
56+
render: () => <Divider key="edit-divider" label={t('common.actions.edit')} labelPosition="center" />,
5757
},
5858
{
5959
order: 700,
60-
render: () => <OpenTabPanel panelID={panelID} viewID={viewID} />,
60+
render: () => <OpenTabPanel key="open-tab-panel" panelID={panelID} viewID={viewID} />,
6161
},
6262
{
6363
order: 800,
64-
render: () => <OpenTabVariable panelID={panelID} viewID={viewID} />,
64+
render: () => <OpenTabVariable key="open-tab-variable" panelID={panelID} viewID={viewID} />,
6565
},
6666
{
6767
order: 900,
68-
render: () => <OpenTabVisualization panelID={panelID} viewID={viewID} />,
68+
render: () => <OpenTabVisualization key="open-tab-visualization" panelID={panelID} viewID={viewID} />,
6969
},
7070
{
7171
order: 1000,
72-
render: () => <OpenTabInteraction panelID={panelID} viewID={viewID} />,
72+
render: () => <OpenTabInteraction key="open-tab-interaction" panelID={panelID} viewID={viewID} />,
7373
},
7474
{
7575
order: 1100,
76-
render: () => <Divider label={t('common.actions.actions')} labelPosition="center" />,
76+
render: () => <Divider key="actions-divider" label={t('common.actions.actions')} labelPosition="center" />,
7777
},
7878
{
7979
order: 1200,
80-
render: () => <Duplicate panelID={panelID} viewID={viewID} />,
80+
render: () => <Duplicate key="duplicate" panelID={panelID} viewID={viewID} />,
8181
},
8282
{
8383
order: 1300,
84-
render: () => <DeletePanel panelID={panelID} viewID={viewID} />,
84+
render: () => <DeletePanel key="delete-panel" panelID={panelID} viewID={viewID} />,
8585
},
8686

8787
...additionalItems,

dashboard/src/components/panel/panel-render/dropdown-menu-items/use-items.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ export const useItems = (view: ViewMetaInstance) => {
1414
const ret: PanelMenuItem[] = [
1515
{
1616
order: 10,
17-
render: () => <Refresh />,
17+
render: () => <Refresh key="refresh" />,
1818
},
1919
{
2020
order: 100,
21-
render: () => <DownloadData />,
21+
render: () => <DownloadData key="download-data" />,
2222
},
2323
{
2424
order: 300,
25-
render: () => <DownloadScreenshot />,
25+
render: () => <DownloadScreenshot key="download-screenshot" />,
2626
},
2727
{
2828
order: 400,
29-
render: () => <EnterFullScreen view={view} />,
29+
render: () => <EnterFullScreen key="enter-full-screen" view={view} />,
3030
},
3131
...additionalItems,
3232
];

website/src/pages/dashboard-render-page/content.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ import { DashboardIsEmpty } from './placeholder';
1414
import { useLanguageContext } from '../../contexts';
1515

1616
const DownloadChartData: PanelMenuItem['render'] = ({ getEchartsOptions }) => {
17-
return <Menu.Item onClick={() => console.log(getEchartsOptions())}>下载图表数据</Menu.Item>;
17+
return (
18+
<Menu.Item key="download-echarts-options" onClick={() => console.log(getEchartsOptions())}>
19+
下载图表数据
20+
</Menu.Item>
21+
);
1822
};
1923

2024
const items = [

0 commit comments

Comments
 (0)