Skip to content

Commit 3852fed

Browse files
committed
chore: ignore *terraform* folders or files
chore: ignore *terraform* folders or files
1 parent fb89f45 commit 3852fed

File tree

5 files changed

+36
-20
lines changed

5 files changed

+36
-20
lines changed

.gitignore

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,6 @@ yarn-error.log*
1515
*.iml
1616
.angular/
1717

18-
.terraform
19-
.terraform.lock.hcl
18+
*.terraform*
19+
*.tfstate*
20+
.terraform.lock.hcl

modules/azure/aks/buildingblock/main.tf

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,14 @@ resource "azurerm_kubernetes_cluster" "aks" {
4949
kubernetes_version = var.kubernetes_version
5050

5151
default_node_pool {
52-
name = "system"
53-
node_count = var.enable_auto_scaling ? null : var.node_count
54-
min_count = var.enable_auto_scaling ? var.min_node_count : null
55-
max_count = var.enable_auto_scaling ? var.max_node_count : null
56-
enable_auto_scaling = var.enable_auto_scaling
57-
vm_size = var.vm_size
58-
os_disk_size_gb = var.os_disk_size_gb
59-
vnet_subnet_id = azurerm_subnet.aks_subnet.id
60-
type = "VirtualMachineScaleSets"
52+
name = "system"
53+
node_count = var.enable_auto_scaling ? null : var.node_count
54+
min_count = var.enable_auto_scaling ? var.min_node_count : null
55+
max_count = var.enable_auto_scaling ? var.max_node_count : null
56+
vm_size = var.vm_size
57+
os_disk_size_gb = var.os_disk_size_gb
58+
vnet_subnet_id = azurerm_subnet.aks_subnet.id
59+
type = "VirtualMachineScaleSets"
6160

6261
upgrade_settings {
6362
max_surge = "10%"
@@ -70,8 +69,11 @@ resource "azurerm_kubernetes_cluster" "aks" {
7069

7170
role_based_access_control_enabled = true
7271

73-
azure_active_directory_role_based_access_control {
74-
admin_group_object_ids = [var.aks_admin_group_object_id]
72+
dynamic "azure_active_directory_role_based_access_control" {
73+
for_each = var.aks_admin_group_object_id != null ? [1] : []
74+
content {
75+
admin_group_object_ids = [var.aks_admin_group_object_id]
76+
}
7577
}
7678

7779
network_profile {
@@ -123,8 +125,7 @@ resource "azurerm_monitor_diagnostic_setting" "aks_monitoring" {
123125
category = "kube-audit"
124126
}
125127

126-
metric {
128+
enabled_metric {
127129
category = "AllMetrics"
128-
enabled = true
129130
}
130131
}

modules/azure/aks/buildingblock/provider.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@ provider "azurerm" {
33
}
44

55
provider "azuread" {}
6-
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
subscription_id = "ffb344c9-26d7-45f5-9ba0-806a024ae697"
2+
resource_group_name = "test-aks-rg"
3+
location = "Germany West Central"
4+
aks_cluster_name = "test-aks-cluster"
5+
dns_prefix = "testaks"
6+
node_count = 3
7+
vm_size = "standard_a2_v2"
8+
kubernetes_version = "1.33.0"
9+
aks_admin_group_object_id = "12345678-1234-1234-1234-123456789012"
10+
vnet_address_space = "10.1.0.0/16"
11+
subnet_address_prefix = "10.1.0.0/20"
12+
service_cidr = "10.2.0.0/16"
13+
dns_service_ip = "10.2.0.10"
14+
log_analytics_workspace_name = "test-law"

modules/azure/aks/buildingblock/variables.tf

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ variable "os_disk_size_gb" {
119119
variable "kubernetes_version" {
120120
type = string
121121
description = "Kubernetes version for the AKS cluster"
122-
default = "1.29.2"
122+
default = "1.33.0"
123123

124124
validation {
125125
condition = can(regex("^[0-9]+\\.[0-9]+\\.[0-9]+$", var.kubernetes_version))
@@ -129,11 +129,12 @@ variable "kubernetes_version" {
129129

130130
variable "aks_admin_group_object_id" {
131131
type = string
132-
description = "Object ID of the Azure AD group used for AKS admin access"
132+
description = "Object ID of the Azure AD group used for AKS admin access. If null, Azure AD RBAC will not be configured."
133+
default = null
133134

134135
validation {
135-
condition = can(regex("^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$", var.aks_admin_group_object_id))
136-
error_message = "Admin group object ID must be a valid GUID."
136+
condition = var.aks_admin_group_object_id == null || can(regex("^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$", var.aks_admin_group_object_id))
137+
error_message = "Admin group object ID must be a valid GUID or null."
137138
}
138139
}
139140

0 commit comments

Comments
 (0)