Skip to content

sanity check output is not available in log #14373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kasper93 opened this issue Mar 16, 2025 · 4 comments · May be fixed by #14379
Open

sanity check output is not available in log #14373

kasper93 opened this issue Mar 16, 2025 · 4 comments · May be fixed by #14379
Assignees
@bonzini
Labels
compilers

Comments

@kasper93
Copy link
Contributor

Describe the bug
When sanity check fails, there is only log

meson.build:1:0: ERROR: Executables created by c compiler x86_64-w64-mingw32-gcc  are not runnable.

without any more information in log or anywhere.

To Reproduce
Try to build something and see the output of sanity check.

Expected behavior
Sanity check log is visible. Especially when running through exe_wrapper like wine, it's important to see why it actually fails.
@bonzini
Copy link
Collaborator

bonzini commented Mar 17, 2025

Can you provide some kind of reproduction instructions?

@bonzini bonzini self-assigned this Mar 17, 2025
@bonzini bonzini added the needs-info waiting information from user. May close if no response for long time. label Mar 17, 2025
@kasper93
Copy link
Contributor Author

https://github.com/kasper93/meson-rust for example https://github.com/kasper93/meson-rust/actions/runs/13888788100/job/38857189704 shows only

meson.build:1:0: ERROR: Executables created by Rust compiler rustc --target x86_64-pc-windows-gnu -C linker=x86_64-w64-mingw32-gcc-posix are not runnable.

without additional info. The real reason for this failure is that wine cannot find rust binary, because of missing .exe extension. But wine output is not available to know that.

It's not limited to rust, c sanity check also doesn't log output. This can be easily reproducible by setting WINEARCH=win32 on x64_64 build for example.

bonzini added a commit to bonzini/meson that referenced this issue Mar 17, 2025
@bonzini
compilers: introduce common helper for sanity checks
98326cc 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
@bonzini
Copy link
Collaborator

bonzini commented Mar 17, 2025

It's not limited to rust, c sanity check also doesn't log output. This can be easily reproducible by setting WINEARCH=win32 on x64_64 build for example.

Yep, I noticed that while looking at a fix. #14379 will be the PR for this once it's tested.

bonzini added a commit to bonzini/meson that referenced this issue Mar 17, 2025
@bonzini
compilers: introduce common helper for sanity checks
d7128f0 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
@bonzini bonzini added compilers and removed needs-info waiting information from user. May close if no response for long time. labels Mar 17, 2025
bonzini added a commit to bonzini/meson that referenced this issue Mar 17, 2025
@bonzini
compilers: introduce common helper for sanity checks
211a5ac 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini added a commit to bonzini/meson that referenced this issue Mar 17, 2025
@bonzini
compilers: introduce common helper for sanity checks
9db9e7d 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini added a commit to bonzini/meson that referenced this issue Mar 25, 2025
@bonzini
compilers: introduce common helper for sanity checks
35420db 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini added a commit to bonzini/meson that referenced this issue Mar 25, 2025
@bonzini
compilers: introduce common helper for sanity checks
c563904 
Avoid reinventing the wheel and instead use a single helper, taking care
of logging and cross compilation.

Fixes: mesonbuild#14373
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini added a commit to bonzini/meson that referenced this issue Apr 2, 2025
@bonzini
environment: remove incorrect check for subproject options
5531f48 
Because this check is done on the actual key, it will fail even if
"subproject:project options" is used.  The correct test is already
performed in mfilestr2key.

Fixes: mesonbuild#14373
@dcbaker dcbaker closed this as completed in 8e92f1e Apr 2, 2025
@eli-schwartz eli-schwartz mentioned this issue Apr 2, 2025
Merged
@eli-schwartz
Copy link
Member

#14438 had an incorrect commit message that referenced this ticket.

@eli-schwartz eli-schwartz reopened this Apr 2, 2025
@eli-schwartz eli-schwartz linked a pull request Apr 2, 2025 that will close this issue
improve and unify logging for sanity checks #14379
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bonzini bonzini

Labels
compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve and unify logging for sanity checks bonzini/meson
3 participants
@bonzini @kasper93 @eli-schwartz