[Style] if true { return } vs (true).then_some(()).ok_or(Error)?

[meowjesty]

Another style question, which of these should we be using:

1. Early return error with if:

if is_wrong(value) {
    return Err(Error::WrongValue(value));
}

2. bool to Option to Result chaining:

(!is_wrong(value))
        .then_some(())
        .ok_or(Error::WrongValue(value))?;

The example in 2 could also be flipped to be:

(is_right(value))
        .then_some(())
        .ok_or(Error::WrongValue(value))?;

A real example of 2 can be found in socket::ops (and in other places in layer as well).