Skip to content

Commit edd72db

Browse files
committed
fix for #858
1 parent 5a376ab commit edd72db

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

api.include.php

+8-1
Original file line numberDiff line numberDiff line change
@@ -7963,7 +7963,11 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79637963
if (strlen($newPassword) < $passwordLength) {
79647964
return $this->responder->error(ErrorCode::PASSWORD_TOO_SHORT, $passwordLength);
79657965
}
7966-
$users = $this->db->selectAll($table, $columnNames, $condition, $columnOrdering, 0, 1);
7966+
$userColumns = $columnNames;
7967+
if(!in_array($pkName, $columnNames)){
7968+
array_push($userColumns, $pkName);
7969+
}
7970+
$users = $this->db->selectAll($table, $userColumns, $condition, $columnOrdering, 0, 1);
79677971
foreach ($users as $user) {
79687972
if (password_verify($password, $user[$passwordColumnName]) == 1) {
79697973
if (!headers_sent()) {
@@ -7972,6 +7976,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79727976
$data = [$passwordColumnName => password_hash($newPassword, PASSWORD_DEFAULT)];
79737977
$this->db->updateSingle($table, $data, $user[$pkName]);
79747978
unset($user[$passwordColumnName]);
7979+
if(!in_array($pkName, $columnNames)){
7980+
unset($user[$pkName]);
7981+
}
79757982
return $this->responder->success($user);
79767983
}
79777984
}

api.php

+8-1
Original file line numberDiff line numberDiff line change
@@ -7963,7 +7963,11 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79637963
if (strlen($newPassword) < $passwordLength) {
79647964
return $this->responder->error(ErrorCode::PASSWORD_TOO_SHORT, $passwordLength);
79657965
}
7966-
$users = $this->db->selectAll($table, $columnNames, $condition, $columnOrdering, 0, 1);
7966+
$userColumns = $columnNames;
7967+
if(!in_array($pkName, $columnNames)){
7968+
array_push($userColumns, $pkName);
7969+
}
7970+
$users = $this->db->selectAll($table, $userColumns, $condition, $columnOrdering, 0, 1);
79677971
foreach ($users as $user) {
79687972
if (password_verify($password, $user[$passwordColumnName]) == 1) {
79697973
if (!headers_sent()) {
@@ -7972,6 +7976,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79727976
$data = [$passwordColumnName => password_hash($newPassword, PASSWORD_DEFAULT)];
79737977
$this->db->updateSingle($table, $data, $user[$pkName]);
79747978
unset($user[$passwordColumnName]);
7979+
if(!in_array($pkName, $columnNames)){
7980+
unset($user[$pkName]);
7981+
}
79757982
return $this->responder->success($user);
79767983
}
79777984
}

composer.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)