unportable-code: function mod on floating point

[GitMensch]

I'm not sure what this code should do, but I fear it possibly doesn't.
In any case that's invalid COBOL.

stairs.cob, bed,cob, door.cob, trapdoor.cob, button.cob

        *> Use the player's yaw to determine the facing
        EVALUATE FUNCTION MOD(PLAYER-YAW(LK-PLAYER) + 45, 360)
            WHEN < 90
                MOVE "north" TO PLACE-PROPERTY-VALUE(2)
            WHEN < 180
                MOVE "east" TO PLACE-PROPERTY-VALUE(2)
            WHEN < 270
                MOVE "south" TO PLACE-PROPERTY-VALUE(2)
            WHEN OTHER
                MOVE "west" TO PLACE-PROPERTY-VALUE(2)
        END-EVALUATE

... also: this code (and likely surrounding one) exists multiple times, it should possibly be moved to a callable program or copybook as well.

[meyfa]

You are right about the code duplication. A copybook would work, but I think a better solution is to uncouple the specific block type from the associated placement rules. That way, multiple block types could refer to the same abstract placement rule, which would handle things like this.

Regarding FUNCTION MOD: Actually, it works fine. The intention of the code is to rotate asymmetric blocks according to the player's look direction when placing the block. Why is it invalid COBOL? GnuCOBOL accepts it.

[GitMensch]

again - per standard (see the other topic) both arguments must be integers (an expression evaluating to an integer is fine) but PLAYER-YAW is a floating-point argument so that rule is broken (see the updated upstream issue about function documentations).

[meyfa]

(For posterity, this is the relevant comment: #406 (comment))

both arguments must be integers

That is unfortunate. In this case, rounding to an integer before passing to FUNCTION MOD would probably work. However, what about the general case? Do you know of an alternative to FUNCTION MOD that could be used for floats? Or would this have to be extracted into C++?

[GitMensch]

Why not just wrapping the float part into FUNCTION INTEGER()?

[GitMensch]

friendly ping @meyfa (and yes, if you neither want to change the data type of PLAYER-YAW (why?) nor want to use FUNCTION INTEGER( PLAYER-YAW (LK-PLAYER) ) , then you'd need to do the mod on the C/C++ side.