Skip to content

Commit b80161e

Browse files
committed
#378(@nikita-petko): Do not write to the actual setting
#!components: grid-bot
1 parent 2e39f05 commit b80161e

2 files changed

Lines changed: 9 additions & 13 deletions

File tree

services/grid-bot/lib/settings/Providers/GridSettings.cs

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,17 +158,13 @@ public class GridSettings : BaseSettingsProvider, IGridServerDockerSettings, IGr
158158
);
159159

160160
/// <inheritdoc cref="IGridServerDockerSettings.GridServerAdditionalVolumeMappings"/>
161-
public string[] GridServerAdditionalVolumeMappings
162-
{
163-
get => GetOrDefault(
164-
nameof(GridServerAdditionalVolumeMappings),
165-
Array.Empty<string>
166-
);
167-
set => Set(
168-
nameof(GridServerAdditionalVolumeMappings),
169-
value
170-
);
171-
}
161+
public string[] GridServerAdditionalVolumeMappingsSetting => GetOrDefault(
162+
nameof(GridServerAdditionalVolumeMappings),
163+
Array.Empty<string>
164+
);
165+
166+
/// <inheritdoc cref="IGridServerDockerSettings.GridServerAdditionalVolumeMappings"/>
167+
public string[] GridServerAdditionalVolumeMappings { get; set; }
172168

173169
/// <inheritdoc cref="IGridServerDockerSettings.ReservedCoresPerGridServerInstance"/>
174170
public int? ReservedCoresPerGridServerInstance => GetOrDefault<int?>(

services/grid-bot/src/Extensions/IServiceCollectionExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public static IServiceCollection AddJobManager(this IServiceCollection services)
175175
#endif
176176

177177
gridSettings.GridServerAdditionalVolumeMappings = [
178-
..gridSettings.GridServerAdditionalVolumeMappings,
178+
..gridSettings.GridServerAdditionalVolumeMappingsSetting,
179179
$"{gridSettings.GridServerSharedDirectoryInternalScripts}:{gridSettings.GridServerInsideDirectoryInternalScripts}"
180180
];
181181

@@ -367,4 +367,4 @@ public static IServiceCollection AddDiscordEventHandlers(this IServiceCollection
367367

368368
return services;
369369
}
370-
}
370+
}

0 commit comments

Comments
 (0)