Skip to content

Commit 3855dca

Browse files
make MlImage tests not block file for read (dotnet#7029)
1 parent d0aa2c2 commit 3855dca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/Microsoft.ML.Tests/ImagesTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,7 @@ public void MLImageCreationTests(string imageName)
12321232
var dataFile = GetDataPath($"images/{imageName}");
12331233

12341234
using MLImage image1 = MLImage.CreateFromFile(dataFile);
1235-
using FileStream imageStream = new FileStream(dataFile, FileMode.Open, FileAccess.Read);
1235+
using FileStream imageStream = new FileStream(dataFile, FileMode.Open, FileAccess.Read, FileShare.Read);
12361236
using MLImage image2 = MLImage.CreateFromStream(imageStream);
12371237

12381238
Assert.Equal(image1.Tag, image2.Tag);
@@ -1333,7 +1333,7 @@ public void MLImageSourceDisposingTest(string imageName)
13331333
using MLImage image1 = MLImage.CreateFromFile(imageFile);
13341334

13351335
// Create image from stream then close the stream and then try to access the image data
1336-
FileStream stream = new FileStream(imageFile, FileMode.Open, FileAccess.Read, FileShare.None);
1336+
FileStream stream = new FileStream(imageFile, FileMode.Open, FileAccess.Read, FileShare.Read);
13371337
MLImage image2 = MLImage.CreateFromStream(stream);
13381338
stream.Dispose();
13391339
Assert.Equal(image1.Pixels.ToArray(), image2.Pixels.ToArray());
@@ -1349,7 +1349,7 @@ public void MLImageSourceDisposingTest(string imageName)
13491349
image2.Dispose();
13501350

13511351
// Now test image stream contains image data prepended and appended with extra unrelated data.
1352-
stream = new FileStream(imageFile, FileMode.Open, FileAccess.Read, FileShare.None);
1352+
stream = new FileStream(imageFile, FileMode.Open, FileAccess.Read, FileShare.Read);
13531353
MemoryStream ms = new MemoryStream((int)stream.Length);
13541354
for (int i = 0; i < stream.Length; i++)
13551355
{

0 commit comments

Comments
 (0)