Bring back CMYK JPEG support

[proverbian]

Have an Error after running this:

htmldoc -t pdf --webpage --left 4 --right 7 --top 0 --bottom 0 --bodyfont Arial --fontsize 9 --headfootfont Verdana-Bold --headfootsize 1 -f PDF-test.pdf invoiceprintview.php

ERR007: CMYK JPEG files are not supported! (/images/rs_customers/logo/1/rs_logo.jpg)
ERR011: Unable to load image file "/images/rs_customers/logo/1/rs_logo.jpg"!
ERR007: CMYK JPEG files are not supported! (/images/rs_customers/logo/1/rs_logo.jpg)
ERR011: Unable to load image file "/images/rs_customers/logo/1/rs_logo.jpg"!

After converting the Image to RGB, its working fine.
Just wondering if why it doesn't support CMYK.

It was working fine when we are using 1.8.27

Thanks!

[michaelrsweet]

That’s because they were crashing htmldox (issue #6106)

[michaelrsweet]

Commit 530a587 on the old 1.8 branch covered the change...

[michaelrsweet]

OK, tracking this for a possible re-introduction of CMYK JPEG support. Will probably need to look for the Adobe APPE marker to know whether to invert the resulting RGB data from libjpeg (Adobe TN #5116) and add several CMYK JPEG test files. And that's assuming the current crashing issue in libjpeg is fixed... :/

[proverbian]

Hey Michael,

Thanks for your reply.
We have a temporary solution about it.
We convert the actual image from CMYK to sRGB.

Code like this, for others to have an idea incase they encounter this.

// FIX CMYK Image issue
$upload_file = "image.jpg"
$icc_profile = "/home/user/path/sRGB.icc";
$check = shell_exec("identify -verbose $upload_file  | grep Colorspace  2>&1;");

$check = explode(":", $check);
$check = trim($check[1]);

 if ($check == 'CMYK') {
   $out = shell_exec("convert -verbose $upload_file -profile $icc_profile -colorspace sRGB  -compress LZW $upload_file 2>&1;");
 }

Downloaded sRGB.icc here: http://www.color.org/black_scaled_2009_srgb.xalter

Thanks!