remove time unit from metric name

Signed-off-by: Ben Efrati <[email protected]>

Author: BenEfrati

implementations/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricConverter.java

@@ -157,8 +157,7 @@ private static Optional<ExponentialHistogramSnapShot> getExponentialHistogramSna
     }
 
     private void addMaxGaugeForTimer(Meter.Id id, Iterable<KeyValue> tags, double max) {
-        String metricName = id.getName()
-                + (isTimeBasedMeter(id) ? "." + this.baseTimeUnit.toString().toLowerCase() : "") + ".max";
+        String metricName = id.getName() + ".max";
         Metric.Builder metricBuilder = getOrCreateMetricBuilder(id.withName(metricName), DataCase.GAUGE);
         if (!metricBuilder.hasGauge()) {
             metricBuilder.setGauge(io.opentelemetry.proto.metrics.v1.Gauge.newBuilder());

implementations/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp/OTelCollectorIntegrationTest.java

@@ -107,7 +107,7 @@ void collectorShouldExportMetrics() throws Exception {
             // see: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/20519
             matchesPattern("(?s)^.*test_timer_milliseconds_sum\\{.+} 123\\.0\\n.*$"),
             matchesPattern("(?s)^.*test_timer_milliseconds_bucket\\{.+,le=\"\\+Inf\"} 1\\n.*$"),
-            matchesPattern("(?s)^.*test_timer_milliseconds_max\\{.+} 123\\.0\n.*$"),
+            matchesPattern("(?s)^.*test_timer_max_milliseconds\\{.+} 123\\.0\n.*$"),
 
             containsString("# HELP test_ds \n"),
             containsString("# TYPE test_ds histogram\n"),