Do not log HTTP/2 ping from server (#11664)

Also add test case that the ping is properly responded to (netty does this for us).

Fixes #10376

Co-authored-by: Sergio del Amo <[email protected]>

Author: yawkat

http-client/src/main/java/io/micronaut/http/client/netty/ConnectionManager.java

@@ -68,6 +68,7 @@
 import io.netty.handler.codec.http2.Http2HeadersFrame;
 import io.netty.handler.codec.http2.Http2MultiplexActiveStreamsException;
 import io.netty.handler.codec.http2.Http2MultiplexHandler;
+import io.netty.handler.codec.http2.Http2PingFrame;
 import io.netty.handler.codec.http2.Http2SettingsAckFrame;
 import io.netty.handler.codec.http2.Http2SettingsFrame;
 import io.netty.handler.codec.http2.Http2StreamChannel;
@@ -839,7 +840,7 @@ public void handlerAdded(ChannelHandlerContext ctx) throws Exception {
 
             @Override
             public void channelRead(@NonNull ChannelHandlerContext ctx, @NonNull Object msg) throws Exception {
-                if (msg instanceof Http2SettingsAckFrame) {
+                if (msg instanceof Http2SettingsAckFrame || msg instanceof Http2PingFrame) {
                     // this is fine
                     return;
                 }

http-client/src/test/groovy/io/micronaut/http/client/netty/ConnectionManagerSpec.groovy

@@ -50,6 +50,7 @@ import io.netty.handler.codec.http2.DefaultHttp2DataFrame
 import io.netty.handler.codec.http2.DefaultHttp2GoAwayFrame
 import io.netty.handler.codec.http2.DefaultHttp2Headers
 import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame
+import io.netty.handler.codec.http2.DefaultHttp2PingFrame
 import io.netty.handler.codec.http2.Http2Error
 import io.netty.handler.codec.http2.Http2FrameCodec
 import io.netty.handler.codec.http2.Http2FrameCodecBuilder
@@ -1245,6 +1246,38 @@ class ConnectionManagerSpec extends Specification {
         'micronaut.http.client.http2.ping-interval-idle'  | true
     }
 
+    def 'http2 server ping'() {
+        given:
+        def ctx = ApplicationContext.run([
+                'micronaut.http.client.ssl.insecure-trust-all-certificates': true,
+                'spec.name': ConnectionManagerSpec.simpleName,
+        ])
+        def client = ctx.getBean(DefaultHttpClient)
+
+        def conn = new EmbeddedTestConnectionHttp2()
+        conn.setupHttp2Tls()
+        patch(client, conn)
+
+        def future = conn.testExchangeRequest(client)
+        conn.exchangeSettings()
+        conn.testExchangeResponse(future)
+
+        assertPoolConnections(client, 1)
+
+        conn.serverChannel.writeAndFlush(new DefaultHttp2PingFrame(123))
+        conn.advance()
+
+        expect:
+        def pong = conn.serverChannel.readInbound()
+        pong instanceof Http2PingFrame
+        pong.ack
+        pong.content == 123
+
+        cleanup:
+        client.close()
+        ctx.close()
+    }
+
     void assertPoolConnections(DefaultHttpClient client, int count) {
         assert client.connectionManager.getChannels().size() == count
         client.connectionManager.getChannels().forEach { assert it.isActive() }