Skip to content

ReadTimeoutException is missing "serviceId" #11794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frank-mueller-at-kiwigrid-com opened this issue May 6, 2025 · 0 comments · May be fixed by #11795
Open

ReadTimeoutException is missing "serviceId" #11794

frank-mueller-at-kiwigrid-com opened this issue May 6, 2025 · 0 comments · May be fixed by #11795
Labels
status: example attached type: bug Something isn't working

Comments

@frank-mueller-at-kiwigrid-com
Copy link

frank-mueller-at-kiwigrid-com commented May 6, 2025 •
edited
Loading

Expected Behavior

To be able to detect which service did not respond within timeout, attribute "serviceId" should be set for ReadTimeoutException.

Actual Behaviour

attribute "serviceId" is null

Steps To Reproduce

From reading the code https://github.com/micronaut-projects/micronaut-core/blob/4.9.x/http-client-core/src/main/java/io/micronaut/http/client/exceptions/ReadTimeoutException.java
you can see that the only existing constructor of ReadTimeoutException calls the constructor of its superclass HttpClientException with parameter "shared" true.

See

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/exceptions/ReadTimeoutException.java

Line 29 in 2395c23

super("Read Timeout", null, true);

and

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/exceptions/HttpClientException.java

Line 57 in 2395c23

serviceIdLocked = true;

This set attribute "serviceIdLocked" to true, which then never allows to set the "serviceId".
See

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/exceptions/HttpClientException.java

Line 79 in 2395c23

if (serviceIdLocked) {

Environment Information

No response

Example Application

No response

Version

Micronaut Core 4.8.11
Micronaut Platform 4.8.2
altro3 added a commit to altro3/micronaut-core that referenced this issue May 7, 2025
@altro3
Fix HttpClientException serviceId
905540e 
Fixed micronaut-projects#11794
@altro3 altro3 linked a pull request May 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: example attached type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HttpClientException serviceId altro3/micronaut-core
2 participants
@frank-mueller-at-kiwigrid-com @ojebari-ma