Fix logging initialized in annotation processor (#2452)

* Fix logging initialized in annotation processor

* Correct

Author: dstepanov

data-model/src/main/java/io/micronaut/data/model/AbstractPersistentEntity.java

@@ -15,6 +15,7 @@
  */
 package io.micronaut.data.model;
 
+import io.micronaut.core.annotation.Internal;
 import io.micronaut.core.annotation.NonNull;
 import io.micronaut.core.annotation.Nullable;
 import io.micronaut.core.annotation.AnnotationMetadata;
@@ -24,8 +25,6 @@
 import io.micronaut.core.reflect.InstantiationUtils;
 import io.micronaut.data.annotation.MappedEntity;
 import io.micronaut.data.model.naming.NamingStrategy;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.util.Map;
 import java.util.Optional;
@@ -37,10 +36,9 @@
  * @author graemerocher
  * @since 1.0.0
  */
+@Internal
 public abstract class AbstractPersistentEntity implements PersistentEntity {
 
-    private static final Logger LOG = LoggerFactory.getLogger(AbstractPersistentEntity.class);
-
     private static final Map<String, NamingStrategy> NAMING_STRATEGIES = new ConcurrentHashMap<>(3);
 
     private final AnnotationMetadataProvider annotationMetadataProvider;
@@ -56,6 +54,16 @@ protected AbstractPersistentEntity(AnnotationMetadataProvider annotationMetadata
         this.namingStrategy = getNamingStrategy(annotationMetadataProvider.getAnnotationMetadata());
     }
 
+    /**
+     * Log error message.
+     *
+     * @param message The message
+     * @param e       The exception
+     */
+    protected void logDebug(String message, Exception e) {
+        System.err.println(message + " " + e.getMessage());
+    }
+
     @NonNull
     @Override
     public String getAliasName() {
@@ -71,7 +79,7 @@ private NamingStrategy getNamingStrategy(AnnotationMetadata annotationMetadata)
     }
 
     @NonNull
-    private static Optional<NamingStrategy> getNamingStrategy(String className, ClassLoader classLoader) {
+    private Optional<NamingStrategy> getNamingStrategy(String className, ClassLoader classLoader) {
         NamingStrategy namingStrategy = NAMING_STRATEGIES.get(className);
         if (namingStrategy != null) {
             return Optional.of(namingStrategy);
@@ -87,9 +95,7 @@ private static Optional<NamingStrategy> getNamingStrategy(String className, Clas
                     }
                 }
             } catch (Exception e) {
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("Tried, but could not instantiate naming strategy: {}", className, e);
-                }
+                logDebug("Tried, but could not instantiate naming strategy: " + className, e);
             }
             Object o = InstantiationUtils.tryInstantiate(className, classLoader).orElse(null);
             if (o instanceof NamingStrategy ns) {

data-model/src/main/java/io/micronaut/data/model/runtime/RuntimePersistentEntity.java

@@ -28,6 +28,8 @@
 import io.micronaut.data.exceptions.MappingException;
 import io.micronaut.data.model.*;
 import io.micronaut.data.model.runtime.convert.AttributeConverter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.*;
 import java.util.stream.Collectors;
@@ -41,6 +43,8 @@
  */
 public class RuntimePersistentEntity<T> extends AbstractPersistentEntity implements PersistentEntity {
 
+    private static final Logger LOG = LoggerFactory.getLogger(RuntimePersistentEntity.class);
+
     private final BeanIntrospection<T> introspection;
     private final RuntimePersistentProperty<T>[] identity;
 
@@ -129,6 +133,11 @@ public RuntimePersistentEntity(@NonNull BeanIntrospection<T> introspection) {
         this.aliasName = super.getAliasName();
     }
 
+    @Override
+    protected void logDebug(String message, Exception e) {
+        LOG.debug(message, e);
+    }
+
     private static EnumSet<Relation.Cascade> cascades(RuntimePersistentEntity<?> persistentEntity) {
         EnumSet<Relation.Cascade> cascades = EnumSet.noneOf(Relation.Cascade.class);
         for (RuntimeAssociation<?> association : persistentEntity.getAssociations()) {

settings.gradle

@@ -123,6 +123,8 @@ include 'doc-examples:hibernate-spring-tx-example-java'
 
 include 'doc-examples:jooq-r2dbc-postgres'
 
+include 'test-annotation-processor-java'
+
 // benchmarks
 include 'benchmarks:benchmark-micronaut-data-jpa'
 include 'benchmarks:benchmark-micronaut-data-jdbc'

test-annotation-processor-java/build.gradle

@@ -0,0 +1,19 @@
+
+plugins {
+    id "io.micronaut.build.internal.data-tck"
+}
+
+tasks.named("test") {
+    useJUnitPlatform()
+}
+
+dependencies {
+    testImplementation projects.micronautDataProcessor
+    testImplementation mn.micronaut.inject.java.test
+    testImplementation libs.jupiter.api
+    testRuntimeOnly libs.jupiter.engine
+}
+
+configurations.configureEach {
+    exclude group: "ch.qos.logback"
+}

test-annotation-processor-java/gradle.properties

@@ -0,0 +1 @@
+skipDocumentation=true

test-annotation-processor-java/src/main/java/example/Application.java

@@ -0,0 +1,8 @@
+
+package example;
+
+public class Application {
+
+    public static void main(String[] args) {
+    }
+}

test-annotation-processor-java/src/test/java/example/AnnotationProcessorTest.java

@@ -0,0 +1,49 @@
+package example;
+
+import io.micronaut.annotation.processing.test.JavaParser;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+
+class AnnotationProcessorTest {
+
+    @Test
+    void testSlf4jIsNoBeingInitialized() {
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        PrintStream ps = new PrintStream(baos);
+        PrintStream old = System.err;
+        System.setErr(ps);
+
+        try (JavaParser javaParser = new JavaParser()) {
+            javaParser.generate("xyz.Foo", """
+                    package xyz;
+                    @io.micronaut.data.annotation.Repository
+                    interface FooRepository extends io.micronaut.data.repository.CrudRepository<Foo, Long> {
+                    }
+                    @io.micronaut.data.annotation.MappedEntity
+                    class Foo {
+
+                        @io.micronaut.data.annotation.Id
+                        private Long id;
+
+                        public Long getId() {
+                            return id;
+                        }
+
+                        public void setId(Long id) {
+                            this.id = id;
+                        }
+
+                    }
+                    """);
+        }
+
+        System.err.flush();
+        System.setErr(old);
+
+        Assertions.assertEquals("", baos.toString());
+    }
+
+}