Skip to content

Commit fa25c64

Browse files
committed
Merge branch '1.5.x' into kotlin-fix
# Conflicts: # sourcegen-generator-kotlin/src/main/kotlin/io/micronaut/sourcegen/KotlinPoetSourceGenerator.kt # sourcegen-generator-kotlin/src/test/kotlin/io/micronaut/sourcegen/AnnotationTest.kt
2 parents ff87a00 + 86e5c40 commit fa25c64

File tree

27 files changed

+225
-150
lines changed

27 files changed

+225
-150
lines changed

build-logic/build.gradle.kts

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
plugins {
2+
id("groovy-gradle-plugin")
3+
}
4+
5+
repositories {
6+
gradlePluginPortal()
7+
mavenCentral()
8+
}
9+
10+
dependencies {
11+
implementation(libs.micronaut.gradle.plugin)
12+
}

buildSrc/settings.gradle build-logic/settings.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
dependencyResolutionManagement {
22
versionCatalogs {
3-
libs {
3+
create("libs") {
44
from(files("../gradle/libs.versions.toml"))
55
}
66
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
plugins {
2+
id("io.micronaut.build.internal.sourcegen-base")
3+
id("io.micronaut.build.internal.module")
4+
}
5+
6+
micronautBuild {
7+
binaryCompatibility {
8+
enabled.set(false)
9+
}
10+
}

buildSrc/src/main/groovy/io.micronaut.build.internal.sourcegen-testsuite.gradle build-logic/src/main/groovy/io.micronaut.build.internal.sourcegen-testsuite.gradle

-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,3 @@ tasks.withType(Test).configureEach {
1010
tasks.withType(Checkstyle).configureEach {
1111
enabled = false
1212
}
13-
14-
if (System.getenv("SONAR_TOKEN") != null) {
15-
tasks.configureEach { if (it.name == "testCodeCoverageReport") { enabled = false } }
16-
}

build.gradle

-14
This file was deleted.

build.gradle.kts

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
plugins {
2+
id("io.micronaut.build.internal.sourcegen-base")
3+
id("io.micronaut.build.internal.docs")
4+
id("io.micronaut.build.internal.quality-reporting")
5+
}
6+
7+
if (System.getenv("SONAR_TOKEN") != null) {
8+
tasks.named("testCodeCoverageReport") { enabled = false }
9+
}
10+
11+
afterEvaluate {
12+
configurations.javadocAggregatorBase.configure {
13+
dependencies.removeIf {
14+
it.name.startsWith("test-suite")
15+
}
16+
}
17+
}

buildSrc/build.gradle

-14
This file was deleted.

buildSrc/src/main/groovy/io.micronaut.build.internal.sourcegen-module.gradle

-10
This file was deleted.

gradle.properties

+6-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
projectVersion=1.5.4-SNAPSHOT
1+
projectVersion=1.5.5-SNAPSHOT
22
projectGroup=io.micronaut.sourcegen
33

44
title=Compilation time source code generators
@@ -7,12 +7,9 @@ projectUrl=https://micronaut.io
77
githubSlug=micronaut-projects/micronaut-sourcegen
88
developers=Denis Stepanov
99

10-
# Micronaut core branch for BOM pull requests
11-
githubCoreBranch=3.8.x
12-
13-
# bomProperty=micronautXXXVersion
14-
# If needed, set additional properties
15-
# bomProperties=hibernateVersion,tomcatJdbcVersion
16-
10+
org.gradle.jvmargs=-Xmx2g -Dfile.encoding=UTF-8
11+
org.gradle.configuration-cache=false
12+
org.gradle.configuration-cache.parallel=false
1713
org.gradle.caching=true
18-
org.gradle.jvmargs=-Xmx1g
14+
org.gradle.parallel=true
15+
kotlin.stdlib.default.dependency=false

gradle/libs.versions.toml

+11-14
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
[versions]
2-
micronaut = "4.7.10"
3-
micronaut-platform = "4.6.3"
4-
micronaut-docs = "2.0.0"
5-
micronaut-test = "4.1.0"
6-
micronaut-data = "4.9.6"
7-
micronaut-validation = "4.8.0"
8-
micronaut-gradle-plugin = "4.4.4"
92
managed-kotlinpoet = "2.0.0"
3+
104
google-truth = "1.4.4"
115
google-compile-testing = "0.21.0"
126
google-jimfs = "1.3.0"
13-
kotlin = '1.9.25'
14-
ksp = '1.9.24-1.0.20'
157
asm = "9.7.1"
16-
intellij-java-decompiler = "242.23726.103"
8+
intellij-java-decompiler = "243.22562.218"
9+
10+
micronaut = "4.7.10"
11+
micronaut-platform = "4.7.3"
12+
micronaut-docs = "2.0.0"
13+
micronaut-test = "4.6.2"
14+
micronaut-data = "4.10.5"
15+
micronaut-validation = "4.8.0"
16+
micronaut-gradle-plugin = "4.4.4"
1717

1818
[libraries]
19-
# Core
19+
# Micronaut
2020
micronaut-core = { module = 'io.micronaut:micronaut-core-bom', version.ref = 'micronaut' }
2121
micronaut-data = { module = 'io.micronaut.data:micronaut-data-bom', version.ref = 'micronaut-data' }
2222
micronaut-validation = { module = "io.micronaut.validation:micronaut-validation-bom", version.ref = "micronaut-validation" }
@@ -32,9 +32,6 @@ asm-tree = { module = "org.ow2.asm:asm-tree", version.ref = "asm" }
3232
google-truth = { module = "com.google.truth:truth", version.ref = "google-truth" }
3333
google-compile-testing = { module = "com.google.testing.compile:compile-testing", version.ref = "google-compile-testing" }
3434
google-jimfs = { module = "com.google.jimfs:jimfs", version.ref = "google-jimfs" }
35-
junit-jupiter-engine = { module = "org.junit.jupiter:junit-jupiter-engine" }
3635

3736
micronaut-gradle-plugin = { module = "io.micronaut.gradle:micronaut-gradle-plugin", version.ref="micronaut-gradle-plugin" }
38-
kotlin-gradle-plugin = { module = 'org.jetbrains.kotlin:kotlin-gradle-plugin', version.ref = 'kotlin' }
39-
kotlin-gradle-allopen = { module = 'org.jetbrains.kotlin:kotlin-allopen', version.ref = 'kotlin' }
4037
intellij-java-decompiler = { module = 'com.jetbrains.intellij.java:java-decompiler-engine', version.ref = 'intellij-java-decompiler' }

gradle/wrapper/gradle-wrapper.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

gradlew

+1-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ done
8686
# shellcheck disable=SC2034
8787
APP_BASE_NAME=${0##*/}
8888
# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
89-
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s
90-
' "$PWD" ) || exit
89+
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit
9190

9291
# Use the maximum available, or set MAX_FD != -1 to use that value.
9392
MAX_FD=maximum

settings.gradle.kts

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ pluginManagement {
55
}
66
}
77

8+
includeBuild("build-logic")
9+
810
plugins {
9-
id("io.micronaut.build.shared.settings") version "7.2.3"
11+
id("io.micronaut.build.shared.settings") version "7.3.2"
1012
}
1113

1214
rootProject.name = "sourcegen-parent"
@@ -40,4 +42,3 @@ dependencyResolutionManagement {
4042
mavenCentral()
4143
}
4244
}
43-

sourcegen-bytecode-writer/build.gradle.kts

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,18 @@ repositories {
1010

1111
dependencies {
1212
api(projects.sourcegenModel)
13-
compileOnly(mn.micronaut.core.processor)
1413
api(libs.asm)
1514
api(libs.asm.commons)
1615
api(libs.asm.util)
16+
17+
compileOnly(mn.micronaut.core.processor)
18+
1719
testImplementation(mn.micronaut.core.processor)
18-
testImplementation(libs.junit.jupiter.engine)
20+
testImplementation(mnTest.junit.jupiter.api)
1921
testImplementation(libs.intellij.java.decompiler)
2022
testImplementation(projects.testSuiteCustomGenerators)
23+
24+
testRuntimeOnly(mnTest.junit.jupiter.engine)
2125
}
2226

2327
tasks.withType<Test> {

sourcegen-bytecode-writer/src/main/java/io/micronaut/sourcegen/bytecode/ByteCodeWriter.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,11 @@ public void writeClass(ClassVisitor classVisitor, ClassDef classDef, @Nullable C
277277

278278
if (classDef.getMethods().stream().noneMatch(MethodDef::isConstructor)) {
279279
// Add default constructor
280-
writeMethod(classVisitor, classDef, MethodDef.constructor()
280+
MethodDef.MethodDefBuilder defaultConstructor = MethodDef.constructor();
281+
if (classDef.getModifiers().contains(Modifier.PUBLIC)) {
282+
defaultConstructor.addModifiers(Modifier.PUBLIC);
283+
}
284+
writeMethod(classVisitor, classDef, defaultConstructor
281285
.build((aThis, methodParameters) -> aThis.superRef().invokeConstructor(methodParameters)));
282286
}
283287

sourcegen-bytecode-writer/src/main/java/io/micronaut/sourcegen/bytecode/expression/CastExpressionWriter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.objectweb.asm.commons.GeneratorAdapter;
2929

3030
final class CastExpressionWriter implements ExpressionWriter {
31+
3132
private final ExpressionDef.Cast castExpressionDef;
3233

3334
public CastExpressionWriter(ExpressionDef.Cast castExpressionDef) {
@@ -128,7 +129,6 @@ private static ClassTypeDef getSuperclass(ObjectDef objectDef) {
128129
return null;
129130
}
130131

131-
132132
private static void checkCast(GeneratorAdapter generatorAdapter, MethodContext context, TypeDef from, TypeDef to) {
133133
TypeDef toType = ObjectDef.getContextualType(context.objectDef(), to);
134134
if (!toType.makeNullable().equals(from.makeNullable())) {

0 commit comments

Comments
 (0)