Skip to content

Commit 9ddbdb7

Browse files
authoredMar 23, 2023
Re-enable Hibernate reactive support (#195)
Closes #189
1 parent 4c289ab commit 9ddbdb7

File tree

8 files changed

+18
-53
lines changed

8 files changed

+18
-53
lines changed
 

‎config/accepted-api-changes.json

+1-30
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,3 @@
11
[
2-
{
3-
"type": "io.micronaut.testresources.buildtools.KnownModules",
4-
"member": "Field HIBERNATE_REACTIVE_CORE",
5-
"reason": "Hibernate Reactive support temporarily removed"
6-
},
7-
{
8-
"type": "io.micronaut.testresources.buildtools.KnownModules",
9-
"member": "Field HIBERNATE_REACTIVE_MSSQL",
10-
"reason": "Hibernate Reactive support temporarily removed"
11-
},
12-
{
13-
"type": "io.micronaut.testresources.buildtools.KnownModules",
14-
"member": "Field HIBERNATE_REACTIVE_MYSQL",
15-
"reason": "Hibernate Reactive support temporarily removed"
16-
},
17-
{
18-
"type": "io.micronaut.testresources.buildtools.KnownModules",
19-
"member": "Field HIBERNATE_REACTIVE_MARIADB",
20-
"reason": "Hibernate Reactive support temporarily removed"
21-
},
22-
{
23-
"type": "io.micronaut.testresources.buildtools.KnownModules",
24-
"member": "Field HIBERNATE_REACTIVE_POSTGRESQL",
25-
"reason": "Hibernate Reactive support temporarily removed"
26-
},
27-
{
28-
"type": "io.micronaut.testresources.buildtools.KnownModules",
29-
"member": "Field HIBERNATE_REACTIVE_ORACLE_XE",
30-
"reason": "Hibernate Reactive support temporarily removed"
31-
}
2+
323
]

‎settings.gradle

+5-8
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,11 @@ localstackModules.each {
7777
project(":test-resources-localstack-$it").projectDir = file("test-resources-localstack/$projectName")
7878
}
7979

80-
// Hibernate reactive support is currently disabled
81-
// because Hibernate Reactive doesn't support Hibernate 6
82-
if (false) {
83-
hibernateReactiveModules.each {
84-
String projectName = "test-resources-hibernate-reactive-$it"
85-
include projectName
86-
project(":test-resources-hibernate-reactive-$it").projectDir = file("test-resources-hibernate-reactive/$projectName")
87-
}
80+
81+
hibernateReactiveModules.each {
82+
String projectName = "test-resources-hibernate-reactive-$it"
83+
include projectName
84+
project(":test-resources-hibernate-reactive-$it").projectDir = file("test-resources-hibernate-reactive/$projectName")
8885
}
8986

9087
micronautBuild {

‎test-resources-bom/build.gradle.kts

-11
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,3 @@ plugins {
22
id("io.micronaut.build.internal.test-resources-base")
33
id("io.micronaut.build.internal.bom")
44
}
5-
6-
micronautBom {
7-
suppressions {
8-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-core")
9-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-mssql")
10-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-mysql")
11-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-mariadb")
12-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-postgresql")
13-
acceptedLibraryRegressions.add("micronaut-test-resources-hibernate-reactive-oracle-xe")
14-
}
15-
}

‎test-resources-hibernate-reactive/test-resources-hibernate-reactive-core/src/testFixtures/groovy/io/micronaut/testresources/hibernate/reactive/core/Book.groovy

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ package io.micronaut.testresources.hibernate.reactive.core
22

33
import io.micronaut.core.annotation.Introspected
44

5-
import javax.persistence.Id
6-
import javax.persistence.Entity
7-
import javax.persistence.GeneratedValue
8-
import javax.persistence.GenerationType
5+
import jakarta.persistence.Id
6+
import jakarta.persistence.Entity
7+
import jakarta.persistence.GeneratedValue
8+
import jakarta.persistence.GenerationType
99

1010
@Entity
1111
@Introspected

‎test-resources-hibernate-reactive/test-resources-hibernate-reactive-mariadb/src/test/groovy/io/micronaut/testresources/hibernate/reactive/mariadb/StandaloneStartMariaDBTest.groovy

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import io.micronaut.testresources.hibernate.reactive.core.Book
55
import io.micronaut.testresources.hibernate.reactive.core.BookRepository
66
import io.micronaut.testresources.testcontainers.AbstractTestContainersSpec
77
import jakarta.inject.Inject
8+
import spock.lang.PendingFeature
89

910
import java.time.Duration
1011
import java.time.temporal.ChronoUnit
@@ -16,6 +17,7 @@ class StandaloneStartMariaDBTest extends AbstractTestContainersSpec {
1617
@Inject
1718
BookRepository repository
1819

20+
@PendingFeature
1921
def "starts a MariaDB container"() {
2022
def book = new Book(title: "Micronaut for Spring developers")
2123
repository.save(book).block(TEST_TIMEOUT)

‎test-resources-hibernate-reactive/test-resources-hibernate-reactive-mariadb/src/test/groovy/io/micronaut/testresources/hibernate/reactive/mariadb/WithJdbcStartMariaDBTest.groovy

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import io.micronaut.testresources.hibernate.reactive.core.Book
55
import io.micronaut.testresources.hibernate.reactive.core.BookRepository
66
import io.micronaut.testresources.testcontainers.AbstractTestContainersSpec
77
import jakarta.inject.Inject
8+
import spock.lang.PendingFeature
89

910
import java.time.Duration
1011
import java.time.temporal.ChronoUnit
@@ -16,6 +17,7 @@ class WithJdbcStartMariaDBTest extends AbstractTestContainersSpec {
1617
@Inject
1718
BookRepository repository
1819

20+
@PendingFeature
1921
def "starts a MariaDB container"() {
2022
def book = new Book(title: "Micronaut for Spring developers")
2123
repository.save(book).block(TEST_TIMEOUT)

‎test-resources-hibernate-reactive/test-resources-hibernate-reactive-mysql/src/test/groovy/io/micronaut/testresources/hibernate/reactive/mysql/StandaloneStartMySQLDBTest.groovy

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import io.micronaut.testresources.hibernate.reactive.core.Book
55
import io.micronaut.testresources.hibernate.reactive.core.BookRepository
66
import io.micronaut.testresources.testcontainers.AbstractTestContainersSpec
77
import jakarta.inject.Inject
8+
import spock.lang.PendingFeature
89

910
import java.time.Duration
1011
import java.time.temporal.ChronoUnit
@@ -16,6 +17,7 @@ class StandaloneStartMySQLDBTest extends AbstractTestContainersSpec {
1617
@Inject
1718
BookRepository repository
1819

20+
@PendingFeature
1921
def "starts a MySQL container"() {
2022
def book = new Book(title: "Micronaut for Spring developers")
2123
repository.save(book).block(TEST_TIMEOUT)

‎test-resources-hibernate-reactive/test-resources-hibernate-reactive-mysql/src/test/groovy/io/micronaut/testresources/hibernate/reactive/mysql/WithJdbcStartMySQLDBTest.groovy

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import io.micronaut.testresources.hibernate.reactive.core.Book
55
import io.micronaut.testresources.hibernate.reactive.core.BookRepository
66
import io.micronaut.testresources.testcontainers.AbstractTestContainersSpec
77
import jakarta.inject.Inject
8+
import spock.lang.PendingFeature
89

910
import java.time.Duration
1011
import java.time.temporal.ChronoUnit
@@ -16,6 +17,7 @@ class WithJdbcStartMySQLDBTest extends AbstractTestContainersSpec {
1617
@Inject
1718
BookRepository repository
1819

20+
@PendingFeature
1921
def "starts a MySQL container"() {
2022
def book = new Book(title: "Micronaut for Spring developers")
2123
repository.save(book).block(TEST_TIMEOUT)

0 commit comments

Comments
 (0)
Please sign in to comment.