stop calls to addGifFrameAsyncDelay to prevent collection of screenshots

Author: Ujjwal Srivastava

agent/src/main/java/com/microsoft/hydralab/agent/runner/appium/AppiumListener.java

@@ -129,7 +129,9 @@ public void testStarted(Description description) {
 
         testRun.addNewTestUnit(ongoingTestUnit);
 
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
         performanceTestListener.testStarted(ongoingTestUnit.getTitle());
     }
 

agent/src/main/java/com/microsoft/hydralab/agent/runner/appium/Junit5Listener.java

@@ -191,7 +191,9 @@ public void executionStarted(TestIdentifier testIdentifier) {
 
         testRun.addNewTestUnit(ongoingTestUnit);
 
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
 
         performanceTestListener.testStarted(ongoingTestUnit.getTitle());
     }

agent/src/main/java/com/microsoft/hydralab/agent/runner/espresso/EspressoTestInfoProcessorListener.java

@@ -153,7 +153,9 @@ public void testStarted(TestIdentifier test) {
 
         testRun.addNewTestUnit(ongoingTestUnit);
 
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
 
         performanceTestListener.testStarted(ongoingTestUnit.getTitle());
     }

agent/src/main/java/com/microsoft/hydralab/agent/runner/maestro/MaestroListener.java

@@ -56,7 +56,9 @@ public void testRunStarted() {
         testRunDeviceOrchestrator.setRunningTestName(testRunDevice, "MaestroTest.testRunStarted");
         performanceTestListener.testRunStarted();
         performanceTestListener.testStarted("MaestroTestCase" + index);
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
     }
 
     private void initUnitCase(String caseName, int testSeconds) {
@@ -75,7 +77,9 @@ private void initUnitCase(String caseName, int testSeconds) {
         testRun.addNewTimeTag(unitIndex + ". " + ongoingTestUnit.getTitle(),
                 System.currentTimeMillis() - testSeconds * 1000 - recordingStartTimeMillis);
         testRunDeviceOrchestrator.setRunningTestName(testRunDevice, ongoingTestUnit.getTitle());
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
         performanceTestListener.testStarted("MaestroTestCase" + index);
     }
 

agent/src/main/java/com/microsoft/hydralab/agent/runner/monkey/AdbMonkeyRunner.java

@@ -124,7 +124,9 @@ public long runMonkeyTestOnce(TestRunDevice testRunDevice, TestTask testTask, Te
         testRun.addNewTestUnit(ongoingMonkeyTest);
 
         logger.info(ongoingMonkeyTest.getTitle());
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 2, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 2, logger);
+        }
         //run monkey test
         testRun.addNewTimeTag(unitIndex + ". " + ongoingMonkeyTest.getTitle(),
                 System.currentTimeMillis() - testRun.getTestStartTimeMillis());

agent/src/main/java/com/microsoft/hydralab/agent/runner/monkey/AppiumMonkeyRunner.java

@@ -72,7 +72,9 @@ protected File runAndGetGif(File appiumJarFile, String appiumCommand, TestRunDev
         testRun.addNewTimeTag(1 + ". " + ongoingMonkeyTest.getTitle(),
                 System.currentTimeMillis() - recordingStartTimeMillis);
         testRunDeviceOrchestrator.setRunningTestName(testRunDevice, ongoingMonkeyTest.getTitle());
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
+        }
         testRun.setTestStartTimeMillis(System.currentTimeMillis());
 
         performanceTestManagementService.testStarted(ongoingMonkeyTest.getTitle());

agent/src/main/java/com/microsoft/hydralab/agent/runner/python/PythonRunner.java

@@ -146,7 +146,9 @@ public long runPythonTest(TestRunDevice testRunDevice, TestTask testTask, TestRu
         testRun.addNewTestUnit(ongoingPythonTest);
 
         logger.info(ongoingPythonTest.getTitle());
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 2, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 2, logger);
+        }
         //run Python test
         testRun.addNewTimeTag(unitIndex + ". " + ongoingPythonTest.getTitle(),
                 System.currentTimeMillis() - testRun.getTestStartTimeMillis());

agent/src/main/java/com/microsoft/hydralab/agent/runner/smart/SmartRunner.java

@@ -121,7 +121,9 @@ public void runSmartTestOnce(int i, TestRunDevice testRunDevice, TestTask testTa
         testRun.addNewTimeTag(unitIndex + ". " + ongoingSmartTest.getTitle(), System.currentTimeMillis() - testRun.getTestStartTimeMillis());
         testRunDeviceOrchestrator.setRunningTestName(testRunDevice, ongoingSmartTest.getTitle());
         logger.info(ongoingSmartTest.getTitle());
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 1, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 1, logger);
+        }
 
         performanceTestManagementService.testStarted(ongoingSmartTest.getTitle());
 

agent/src/main/java/com/microsoft/hydralab/agent/runner/t2c/T2CRunner.java

@@ -128,8 +128,10 @@ private void runT2CJsonTestCase(File jsonFile, TestRunDevice testRunDevice, Test
 
         performanceTestManagementService.testStarted(ongoingTest.getTitle());
 
+
         testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 5, logger);
 
+
         // Run Test
         try {
             runAppiumT2CTest(testRunDevice, jsonFile, logger);

agent/src/main/java/com/microsoft/hydralab/agent/runner/xctest/XCTestRunner.java

@@ -93,7 +93,9 @@ private ArrayList<String> runXctest(TestRunDevice testRunDevice, Logger logger,
         if (testRunDevice.getDeviceInfo() == null) {
             throw new RuntimeException("No such device: " + testRunDevice.getDeviceInfo());
         }
-        testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 0, logger);
+        if (!testTask.isDisableGifEncoder()) {
+            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 0, logger);
+        }
         StringBuilder argString = new StringBuilder();
         Map<String, String> instrumentationArgs = testTask.getTaskRunArgs();
         if (instrumentationArgs != null && !instrumentationArgs.isEmpty()) {
@@ -138,7 +140,9 @@ private ArrayList<String> runXctest(TestRunDevice testRunDevice, Logger logger,
             out.start();
             proc.waitFor();
             result = out.getResult();
-            testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 0, logger);
+            if (!testTask.isDisableGifEncoder()) {
+                testRunDeviceOrchestrator.addGifFrameAsyncDelay(testRunDevice, agentManagementService.getScreenshotDir(), 0, logger);
+            }
         } catch (Exception e) {
             throw new RuntimeException("Execute XCTest failed");
         }