Skip to content

Conversation

@jameslamb
Copy link
Collaborator

Closes #6662

This proposes fully dropping support for datatable.DataTable input in the Python package.

Notes for Reviewers

Benefits of this change

See #6662 for more details.

Why now?

In #6662 I'd originally proposed keeping the support in the package with a deprecation warning for "2-3" releases, and it's only been 1 so far (#6670)... but I think it's safe to make this change. Some evidence:

And specifically, I just observed a case where keeping this around led to extra complexity and effort for a contributor: #6892 (comment)

How I searched for stuff to remove

git grep -i h2o
git grep -i datatable

Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love to see some reduction in complexity 😁

@StrikerRUS StrikerRUS merged commit ec5492f into master Apr 27, 2025
51 checks passed
@StrikerRUS StrikerRUS deleted the drop-datatable branch April 27, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] [python-package] remove h2o datatable support?

4 participants