-
Notifications
You must be signed in to change notification settings - Fork 4k
[c++] Add CPU version of standard R-squared metric #7008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
aa3bcf6
Add R-squared metric, documentation, and tests
nicklamiller ec43778
Fix static ci checks: correct Sklearn r2_score URL link, fix cpp lint…
nicklamiller 6ca5eb6
Replace non-static data members from pragma reduction with variables
nicklamiller cb9ecdf
Merge remote-tracking branch 'upstream/master' into add-r2-metric
nicklamiller 57bda50
Update src/metric/metric.cpp
jameslamb 062d5e6
Merge branch 'master' into add-r2-metric
jameslamb 23a1cf3
Add additional asserts, remove needless y.copy()
nicklamiller d8bc90f
Merge remote-tracking branch 'upstream/master' into add-r2-metric
nicklamiller 472df84
Merge branch 'master' into add-r2-metric
StrikerRUS 33aab02
Merge branch 'master' into add-r2-metric
StrikerRUS b909450
Merge branch 'master' into add-r2-metric
StrikerRUS e5b5868
Add back y.copy()
nicklamiller d49b8b9
Merge remote-tracking branch 'upstream/master' into add-r2-metric
nicklamiller e7871d4
Merge remote-tracking branch 'upstream/master' into add-r2-metric
nicklamiller 340f39c
Merge branch 'master' into add-r2-metric
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to give a heads up, I originally updated the
sum_weights_data member directly in this for-loop, but this resulted in CI failures on some of the R-package jobs for several builds on Windows with the following error (workflow run, line with specific error):So now, the
local_sum_weightsvariable is used in the pragma reduction clause and is updated in the loop, and then assigned tosum_weights_below. I also had to do this for thetotal_sum_squares_member by introducing thelocal_total_sum_squaresvariable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, makes sense to me! I can't think of a better way to do this, I think this small allocation is totally fine.