[ci][c++] fixed whitespace/indent_namespace errors from cpplint
#7056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Oct 12, 2025
StrikerRUS
requested review from
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
borchero
approved these changes
Oct 12, 2025
jameslamb
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
I support this. I'd written "ignore indefinitely" for this check only because I expected it would be a huge diff and didn't personally have a strong preference for either format.
But given that you've already done the work, I'm happy to merge this, to improve the consistency of the code and enforce that automatically going forward. And happy that src/c_api.cpp didn't need to be changed 😅
After this is merged, would you consider doing a followup PR adding this PR's commit to https://github.com/microsoft/LightGBM/blob/master/.git-blame-ignore-revs? That'd skip the mostly-indentation changes in the git blame.
|
Close-reopen to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #7002.
Initially @jameslamb wrote
But given that fixing this error for current codebase is quite straightforward and touches only 10 files, we can merge it and force this setting for the future PRs for the sake of consistent codebase.