Skip to content

Commit a921490

Browse files
committed
Update BuildSource.proj to take in an arbitrary VS version
1 parent af1ee18 commit a921490

File tree

3 files changed

+23
-10
lines changed

3 files changed

+23
-10
lines changed

Diff for: Assets/MRTK/Tools/MSBuild/MSBuildMRTKTemplates/WSA.Player.Template.props.template

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616

1717
<!-- This is for successful building step from dotnet cli -->
1818
<Choose>
19+
<When Condition="'$(XamlTargetsPathOverride)'!= ''">
20+
<PropertyGroup>
21+
<LanguageTargets>$(XamlTargetsPathOverride)\Microsoft.Windows.UI.Xaml.CSharp.targets</LanguageTargets>
22+
</PropertyGroup>
23+
</When>
1924
<When Condition="'$(MSBuildExtensionsPathOverride)'!= ''">
2025
<PropertyGroup>
2126
<LanguageTargets>$(MSBuildExtensionsPathOverride)\Microsoft\WindowsXaml\v15.0\Microsoft.Windows.UI.Xaml.CSharp.targets</LanguageTargets>

Diff for: NuGet/BuildSource.proj

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
22

33
<ItemGroup>
4-
<ProjectReferences Include="..\MSBuild\Projects\MixedRealityToolkit.sln"/>
4+
<ProjectReferences Include="..\MSBuild\Projects\MixedRealityToolkit.sln"/>
55
</ItemGroup>
66

7+
<PropertyGroup>
8+
<XamlTargetsPath>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0</XamlTargetsPath>
9+
</PropertyGroup>
10+
711
<Target Name="BuildStandaloneEditor">
812
<MSBuild Projects="@(ProjectReferences)" Targets="Restore;Build" Properties="Configuration=InEditor;Platform=WindowsStandalone32;BuildProjectReferences=false;GenerateDocumentationFile=true">
913
<Output TaskParameter="TargetOutputs" ItemName="BuildStandaloneEditorOutputs" /><!--AssembliesBuiltByChildProjects-->
@@ -27,15 +31,15 @@
2731
<Output TaskParameter="TargetOutputs" ItemName="BuildAndroidPlayerOutputs" />
2832
</MSBuild>
2933
</Target>
30-
34+
3135
<Target Name="BuildIOSPlayer">
3236
<MSBuild Projects="@(ProjectReferences)" Targets="Restore;Build" Properties="Configuration=Player;Platform=IOS;BuildProjectReferences=false;GenerateDocumentationFile=true">
3337
<Output TaskParameter="TargetOutputs" ItemName="BuildIOSPlayerOutputs" />
3438
</MSBuild>
3539
</Target>
3640

3741
<Target Name="BuildWSAPlayer">
38-
<MSBuild Projects="@(ProjectReferences)" Targets="Restore;Build" Properties="Configuration=Player;Platform=WSA;BuildProjectReferences=false;MSBuildExtensionsPathOverride=C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild;GenerateDocumentationFile=true">
42+
<MSBuild Projects="@(ProjectReferences)" Targets="Restore;Build" Properties="Configuration=Player;Platform=WSA;BuildProjectReferences=false;XamlTargetsPathOverride=$(XamlTargetsPath);GenerateDocumentationFile=true">
3943
<Output TaskParameter="TargetOutputs" ItemName="BuildWSAPlayerOutputs" />
4044
</MSBuild>
4145
</Target>

Diff for: scripts/packaging/createnugetpackages.ps1

+11-7
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,13 @@
1515
param(
1616
[string]$OutputDirectory = ".\artifacts",
1717
[ValidatePattern("^\d+\.\d+\.\d+$")]
18-
[string]$Version,
19-
[string]$UnityDirectory
18+
[string]$Version = "0.0.0",
19+
[Parameter(Mandatory=$true)]
20+
[string]$UnityDirectory,
21+
[string]$VisualStudioDirectory = "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise"
2022
)
2123

2224
Write-Verbose "Reconciling Unity binary:"
23-
if (-not $UnityDirectory) {
24-
throw "-UnityDirectory is a required flag"
25-
}
26-
2725
$unityEditor = Get-ChildItem $UnityDirectory -Filter 'Unity.exe' -Recurse | Select-Object -First 1 -ExpandProperty FullName
2826
if (-not $unityEditor) {
2927
throw "Unable to find the unity editor executable in $UnityDirectory"
@@ -98,7 +96,13 @@ try {
9896
exit($lastexitcode)
9997
}
10098
Write-Output "============ Building Player WSA ============ "
101-
dotnet msbuild .\BuildSource.proj -target:BuildWSAPlayer > "Logs\Build.Player.WSA.$($Version).log"
99+
if ($VisualStudioDirectory -match "2019") {
100+
$VisualStudioDirectory = Join-Path $VisualStudioDirectory "MSBuild\Microsoft\WindowsXaml\v16.0"
101+
}
102+
else {
103+
$VisualStudioDirectory = Join-Path $VisualStudioDirectory "MSBuild\Microsoft\WindowsXaml\v15.0"
104+
}
105+
dotnet msbuild .\BuildSource.proj -target:BuildWSAPlayer /p:XamlTargetsPath=$VisualStudioDirectory > "Logs\Build.Player.WSA.$($Version).log"
102106
if ($lastexitcode -ge 1) {
103107
Write-Error "Building Player WSA Failed! See log file for more information $(Get-Location)\Logs\Build.Player.WSA.$($Version).log";
104108
exit($lastexitcode)

0 commit comments

Comments
 (0)