From aaec6026ed021a189da19ed7a564fd824f15de12 Mon Sep 17 00:00:00 2001 From: Daniel Rentz Date: Tue, 22 Feb 2022 06:36:27 +0100 Subject: [PATCH 1/4] issue 1261: NodeListOf#item NodeListOf#item() misses `null` in return type --- baselines/dom.generated.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index f32fedc45..632e84b10 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9932,7 +9932,7 @@ declare var NodeList: { }; interface NodeListOf extends NodeList { - item(index: number): TNode; + item(index: number): TNode | null; /** * Performs the specified action for each node in an list. * @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the list. From 448cd3a09567f7854411c26073f2c8dbbdba5beb Mon Sep 17 00:00:00 2001 From: Daniel Rentz Date: Tue, 22 Feb 2022 08:38:08 +0100 Subject: [PATCH 2/4] reverted changing generated file --- baselines/dom.generated.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 632e84b10..f32fedc45 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9932,7 +9932,7 @@ declare var NodeList: { }; interface NodeListOf extends NodeList { - item(index: number): TNode | null; + item(index: number): TNode; /** * Performs the specified action for each node in an list. * @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the list. From ea4d1450cf314756986b69668619853f31c750f3 Mon Sep 17 00:00:00 2001 From: Daniel Rentz Date: Tue, 22 Feb 2022 09:20:28 +0100 Subject: [PATCH 3/4] changed return type of NodeListOf#item --- inputfiles/addedTypes.jsonc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index 6fe563b02..2fb2d718d 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -473,7 +473,7 @@ "item": { "name": "item", "overrideSignatures": [ - "item(index: number): TNode" + "item(index: number): TNode | null" ] } } From e3546163247780248b3ee42d9dfdf8e065182538 Mon Sep 17 00:00:00 2001 From: Daniel Rentz Date: Tue, 22 Feb 2022 09:22:36 +0100 Subject: [PATCH 4/4] Update dom.generated.d.ts --- baselines/dom.generated.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index f32fedc45..632e84b10 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9932,7 +9932,7 @@ declare var NodeList: { }; interface NodeListOf extends NodeList { - item(index: number): TNode; + item(index: number): TNode | null; /** * Performs the specified action for each node in an list. * @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the list.