Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exports & dead code (using Knip) #56818

Closed
1 task done
webpro opened this issue Dec 17, 2023 · 1 comment · Fixed by #56817
Closed
1 task done

Remove unused exports & dead code (using Knip) #56818

webpro opened this issue Dec 17, 2023 · 1 comment · Fixed by #56817
Labels
In Discussion Not yet reached consensus Infrastructure Issue relates to TypeScript team infrastructure

Comments

@webpro
Copy link
Contributor

webpro commented Dec 17, 2023

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

Opened a PR (#56817) to clean up some code using Knip.

The removed bits look fairly harmless and safe to merge from my untrained eye. Yet the question is also: should Knip be removed from the PR, or added to the devDependencies and some CI job to make sure regression won't creep in later down the road?

I'll do my part by improving Knip itself and adding it to Knip's integration tests as to not cause you more trouble later.

Thanks a lot for being such a stable source file parser (and so much more), this is a small PR to give something back :)

@RyanCavanaugh RyanCavanaugh added Infrastructure Issue relates to TypeScript team infrastructure In Discussion Not yet reached consensus labels Dec 18, 2023
@RyanCavanaugh
Copy link
Member

Not gonna merge anything infrastructural until people are back from holidays, but we'll discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Discussion Not yet reached consensus Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants