Skip to content

Commit 63bcc2d

Browse files
authored
Update filter condition for HelmInstaller Tasks to filter out pre-releases (#21435)
* update filter condition to remove pre-releases * update HelmInstallerV0 task version * updated HelmInstallerV1 with new kubernetes common package
1 parent fa0baff commit 63bcc2d

File tree

7 files changed

+84
-331
lines changed

7 files changed

+84
-331
lines changed

Tasks/HelmInstallerV0/src/helminstaller.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@ async function getStableHelmVersion(): Promise<string> {
7676
let latestHelmVersion = semver.clean(stableHelmVersion);
7777
responseArray.forEach(response => {
7878
if (response && response.tag_name) {
79-
let currentHelmVerison = semver.clean(response.tag_name.toString());
80-
if (currentHelmVerison) {
81-
if (currentHelmVerison.toString().indexOf('rc') == -1 && semver.gt(currentHelmVerison, latestHelmVersion)) {
79+
let currentHelmVersion = semver.clean(response.tag_name.toString());
80+
if (currentHelmVersion) {
81+
if (!semver.prerelease(currentHelmVersion) && semver.gt(currentHelmVersion, latestHelmVersion)) {
8282
//If current helm version is not a pre release and is greater than latest helm version
83-
latestHelmVersion = currentHelmVerison;
83+
latestHelmVersion = currentHelmVersion;
8484
}
8585
}
8686
}
@@ -110,4 +110,4 @@ function getExecutableExtention(): string {
110110
}
111111

112112
return "";
113-
}
113+
}

Tasks/HelmInstallerV0/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 263,
16+
"Minor": 266,
1717
"Patch": 0
1818
},
1919
"demands": [],

Tasks/HelmInstallerV0/task.loc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 263,
16+
"Minor": 266,
1717
"Patch": 0
1818
},
1919
"demands": [],

0 commit comments

Comments
 (0)