Skip to content

Commit e760feb

Browse files
committed
Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstaller
Prevent installing unreleased final version Related: - helm/helm#31472 We will probably have to limit to v3 soon. Signed-off-by: Benoit Tigeot <[email protected]>
1 parent fa0baff commit e760feb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Tasks/HelmInstallerV0/src/helminstaller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ async function getStableHelmVersion(): Promise<string> {
7575
const responseArray = JSON.parse(fs.readFileSync(downloadPath, 'utf8').toString().trim());
7676
let latestHelmVersion = semver.clean(stableHelmVersion);
7777
responseArray.forEach(response => {
78-
if (response && response.tag_name) {
78+
if (response && response.tag_name && !response.prerelease) {
7979
let currentHelmVerison = semver.clean(response.tag_name.toString());
8080
if (currentHelmVerison) {
81-
if (currentHelmVerison.toString().indexOf('rc') == -1 && semver.gt(currentHelmVerison, latestHelmVersion)) {
81+
if (semver.gt(currentHelmVerison, latestHelmVersion)) {
8282
//If current helm version is not a pre release and is greater than latest helm version
8383
latestHelmVersion = currentHelmVerison;
8484
}

0 commit comments

Comments
 (0)