Nitpicks and cleanup

Author: andystaples

durabletask-azurefunctions/durabletask/azurefunctions/__init__.py

@@ -0,0 +1,2 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.

durabletask-azurefunctions/durabletask/azurefunctions/decorators/durable_app.py

@@ -1,5 +1,6 @@
 #  Copyright (c) Microsoft Corporation. All rights reserved.
 #  Licensed under the MIT License.
+
 import base64
 from functools import wraps
 
@@ -76,7 +77,16 @@ def stub_complete(stub_response):
                     nonlocal response
                     response = stub_response
                 stub.CompleteOrchestratorTask = stub_complete
-                execution_started_events = [e for e in [e1 for e1 in request.newEvents] + [e2 for e2 in request.pastEvents] if e.HasField("executionStarted")]
+                execution_started_events = []
+                for e in request.pastEvents:
+                    if e.HasField("executionStarted"):
+                        execution_started_events.append(e)
+                for e in request.newEvents:
+                    if e.HasField("executionStarted"):
+                        execution_started_events.append(e)
+                if len(execution_started_events) == 0:
+                    raise Exception("No ExecutionStarted event found in orchestration request.")
+
                 function_name = execution_started_events[-1].executionStarted.name
                 worker.add_named_orchestrator(function_name, orchestrator_func)
                 worker._execute_orchestrator(request, stub, None)

durabletask-azurefunctions/durabletask/azurefunctions/internal/azurefunctions_null_stub.py

@@ -1,15 +1,14 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
 
 from durabletask.internal.ProtoTaskHubSidecarServiceStub import ProtoTaskHubSidecarServiceStub
 
 
 class AzureFunctionsNullStub(ProtoTaskHubSidecarServiceStub):
-    """Missing associated documentation comment in .proto file."""
+    """A task hub sidecar stub class that implements all methods as no-ops."""
 
     def __init__(self):
         """Constructor.
-
-        Args:
-            channel: A grpc.Channel.
         """
         self.Hello = lambda *args, **kwargs: None
         self.StartInstance = lambda *args, **kwargs: None

durabletask-azurefunctions/durabletask/azurefunctions/worker.py

@@ -9,7 +9,7 @@
 
 # Worker class used for Durable Task Scheduler (DTS)
 class DurableFunctionsWorker(TaskHubGrpcWorker):
-    """TOOD: Docs
+    """TODO: Docs
     """
 
     def __init__(self):
@@ -27,6 +27,6 @@ def __init__(self):
         self._interceptors = None
 
     def add_named_orchestrator(self, name: str, func):
-        """TOOD: Docs
+        """TODO: Docs
         """
         self._registry.add_named_orchestrator(name, func)

durabletask/internal/ProtoTaskHubSidecarServiceStub.py

@@ -1,8 +1,11 @@
-from typing import Any, Callable
+from typing import Callable
 
 
 class ProtoTaskHubSidecarServiceStub(object):
-    """TODO: Docs"""
+    """A stub class roughly matching the TaskHubSidecarServiceStub generated from the .proto file.
+    Used by Azure Functions during orchestration and entity executions to inject custom behavior,
+    as no real sidecar stub is available.
+    """
 
     def __init__(self):
         """Constructor.