fix: Preset option in Combobox does not work/shows blank combobox

[denispaluca]

🐛 Bug Report

The initial value passed to the Combobox is not shown. The Combobox is empty on first render.

💻 Repro or Code Sample

On the demo website: https://www.fluentui-blazor.net/combobox
Pre-selected option example is empty.

🤔 Expected Behavior

The initial value of the Combobox should be shown.

😯 Current Behavior

The initial value is not shown.

💁 Possible Solution

🔦 Context

🌍 Your Environment

• OS & Device: Windows on PC
• Browser: Microsoft Edge
• .NET and Fluent UI Blazor library Version: 9 and 4.13.0

[MarvinKlein1508]

I will take a look on this on Monday.

[Tyme-Bleyaert]

@MarvinKlein1508 I think you can fix it by doing :

if (OptionSelected != null)
{
    return OptionSelected.Invoke(item);
}
else if (SelectedOption == null && string.IsNullOrEmpty(Value))
{
    return false;
}
else if (OptionValue != null && SelectedOption != null)
{
    return GetOptionValue(item) == GetOptionValue(SelectedOption);
}
else if(!string.IsNullOrEmpty(Value))
{
    return string.Equals(GetOptionValue(item), Value, StringComparison.Ordinal);
}
else
{
    return Equals(item, SelectedOption);
}

instead of :

if (OptionSelected != null)
{
    return OptionSelected.Invoke(item);
}
else if (SelectedOption == null)
{
    return false;
}
else if (OptionValue != null && SelectedOption != null)
{
    return GetOptionValue(item) == GetOptionValue(SelectedOption);
}
else
{
    return Equals(item, SelectedOption);
}

in ListComponentBase.razor.cs.
But you would need to check if SelectedOption needs to have prio over Value or vice versa.

[vnbaaij]

Ik think this change (and order) is fine. I'll create the PR for it.

There is one other issue that we apparently introduced somewhere along the line. According to the text below the combobox in the image the 'Small' value was selected earlier. Not sure if we need to give this much attention. Is it really useful to be able to set a disabled option to selected?