Skip to content

Commit 0bbf3a1

Browse files
authored
Ignore 429 error from markdown-link-check (#1534)
* Change links to point not using urls * Ignore 429 status codes * Change files * Try adding a comment
1 parent ca5c20b commit 0bbf3a1

15 files changed

+47
-32
lines changed

.ado/markdown-link-check-config.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
}
66
],
77
"timeout": "5s",
8-
"aliveStatusCodes": [200, 206, 0, 503]
8+
"aliveStatusCodes": [200, 206, 0, 503, 429],
9+
"statusCodeComment": "429 is ignored as there's no way to fix those other than to try running the pipeline again"
910
}

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ There are some specific quirks to this repository that one should be familiar wi
1515

1616
### Old framework vs new framework (Compose V2)
1717

18-
There's [documentation](https://github.com/microsoft/fluentui-react-native/tree/master/packages/components) for how to author a control, specifically with the two frameworks [foundation-compose](https://github.com/microsoft/fluentui-react-native/tree/master/packages/deprecated/foundation-compose) and [foundation-composable](https://github.com/microsoft/fluentui-react-native/tree/master/packages/deprecated/foundation-composable). Since that documentation was written, we have written a new component framework (PR's [here](https://github.com/microsoft/fluentui-react-native/pull/335) and [here](https://github.com/microsoft/fluentui-react-native/pull/400)) at `packages/experimental/framework` that is simpler/easier to use, and is the new preferred way to create components. Components that use this new framework are located at `packages/experimental` and are copies of the controls located at `packages/components` which still uses the old frameworks. Any new components should use the new framework. The old documentation is still good to read, specifically for using foundation-compose, as a lot of it applies to the new component.
18+
There's [documentation](./packages/components/README.md) for how to author a control, specifically with the two frameworks [foundation-compose](./packages/deprecated/foundation-compose/README.md) and [foundation-composable](./packages/deprecated/foundation-composable/README.md). Since that documentation was written, we have written a new component framework (PR's [here](https://github.com/microsoft/fluentui-react-native/pull/335) and [here](https://github.com/microsoft/fluentui-react-native/pull/400)) at `packages/experimental/framework` that is simpler/easier to use, and is the new preferred way to create components. Components that use this new framework are located at `packages/experimental` and are copies of the controls located at `packages/components` which still uses the old frameworks. Any new components should use the new framework. The old documentation is still good to read, specifically for using foundation-compose, as a lot of it applies to the new component.
1919

2020
There are two directories where components exist, the normal `packages/components` and `packages/experimental`. In general, the `experimental` directory is where components and frameworks we are iterating on get placed.
2121

@@ -31,7 +31,7 @@ One caveat is that if a component simply wraps a single native component, then i
3131

3232
### Tokens
3333

34-
FluentUI React Native (and eventually all of FluentUI) uses the design token system to handle styling / customization. There's extended [documentation](https://github.com/microsoft/fluentui-react-native/blob/master/packages/deprecated/foundation-tokens/README.md) about this in the repo, but here is a simple overview.
34+
FluentUI React Native (and eventually all of FluentUI) uses the design token system to handle styling / customization. There's extended [documentation](./packages/deprecated/foundation-tokens/README.md) about this in the repo, but here is a simple overview.
3535

3636
**Tokens** are things you set at design time, via theme, or via customizing the control. An example might be "brandColor", where each app has it's own color token it sets on all if its controls.
3737

@@ -44,7 +44,7 @@ Tokens help us achieve simpler customization for complex higher order components
4444

4545
This section covers creating and adding a new component package to FluentUI React Native's monorepo. If you are instead working on an existing component and adding a native module, skip to the next two sections.
4646

47-
Most components should use the compose framework as it offers the comprehensive set of patterns like tokens and slots, but if you're creating a simple component that doesn't require those patterns, there's a lighter pattern called [stagedComponent](https://github.com/microsoft/fluentui-react-native/blob/master/packages/framework/use-slot/src/stagedComponent.ts). The stagedComponent pattern splits up the render function into two stages. Stage 1 handles building props and hook calls (best to separate the hook calls from the render tree since they rely on call order). Stage 2 returns the actual element tree, any conditional branching should happen here (Icon is a good example of using stagedCompoenent).
47+
Most components should use the compose framework as it offers the comprehensive set of patterns like tokens and slots, but if you're creating a simple component that doesn't require those patterns, there's a lighter pattern called [stagedComponent](./packages/framework/use-slot/src/stagedComponent.ts). The stagedComponent pattern splits up the render function into two stages. Stage 1 handles building props and hook calls (best to separate the hook calls from the render tree since they rely on call order). Stage 2 returns the actual element tree, any conditional branching should happen here (Icon is a good example of using stagedCompoenent).
4848

4949
1. Create a new directory in of these two locations, depending on your component:
5050

apps/fluent-tester/src/E2E/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
### UWP Additional Prerequisites
1212

13-
- [UWP Prerequisites](https://github.com/microsoft/fluentui-react-native/blob/master/apps/windows/README.md)
13+
- [UWP Prerequisites](../../../windows/README.md)
1414

1515
## MacOS Prerequisites
1616

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Change links to point not using urls",
4+
"packageName": "@fluentui-react-native/composition",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Change links to point not using urls",
4+
"packageName": "@fluentui-react-native/tester",
5+
"email": "[email protected]",
6+
"dependentChangeType": "none"
7+
}

docs/pages/Components/FocusZone.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ These patterns may include navigating a RadioGroup in a circular fashion, or dis
2323

2424
## Props:
2525

26-
| Prop | Type | Default Value | Description |
27-
| ---------------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
28-
| focusZoneDirection | [FocusZoneDirection](https://github.com/microsoft/fluentui-react-native/new/master/docs/pages/Components#focuszonedirection-type) | FocusZoneDirection.bidirectional | Defines which arrows to respond to. |
29-
| disabled | boolean | false | If set, the FocusZone will not be tabbable and keyboard navigation will be disabled. |
30-
| isCircularNavigation | boolean | false | If set, when navigating next from the last element, focus will circle back to the first. And vice versa. |
31-
| defaultTabbableElement | React.RefObject<React.Component> | none | Optionally defined the initial tabbable element inside the FocusZone. If set, when navigating to the FocusZone, focus wil land on this element. |
32-
| use2DNavigation | boolean | false | Allows for 2D navigation. This navigation strategy takes into account the position of elements on screen, and navigates in the direction the user selects to the nearest element. |
33-
| onFocus() | (e?: any) => void; | None | Callback called when “focus” event triggered in FocusZone |
34-
| componentRef | React.RefObject<IFocusable>; | None | A RefObject to access the IFocusable interface. Use this to access the public methods and properties of the component. |
26+
| Prop | Type | Default Value | Description |
27+
| ---------------------- | ------------------------------------------------------------ | -------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
28+
| focusZoneDirection | [FocusZoneDirection](./FocusZone.md#focuszonedirection-type) | FocusZoneDirection.bidirectional | Defines which arrows to respond to. |
29+
| disabled | boolean | false | If set, the FocusZone will not be tabbable and keyboard navigation will be disabled. |
30+
| isCircularNavigation | boolean | false | If set, when navigating next from the last element, focus will circle back to the first. And vice versa. |
31+
| defaultTabbableElement | React.RefObject<React.Component> | none | Optionally defined the initial tabbable element inside the FocusZone. If set, when navigating to the FocusZone, focus wil land on this element. |
32+
| use2DNavigation | boolean | false | Allows for 2D navigation. This navigation strategy takes into account the position of elements on screen, and navigates in the direction the user selects to the nearest element. |
33+
| onFocus() | (e?: any) => void; | None | Callback called when “focus” event triggered in FocusZone |
34+
| componentRef | React.RefObject<IFocusable>; | None | A RefObject to access the IFocusable interface. Use this to access the public methods and properties of the component. |
3535

3636
### FocusZoneDirection Type
3737

docs/pages/Guides/PortingFromFluentUI.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ FURN is a React Native based component library, so there will be a few differenc
1111

1212
## Styling
1313

14-
CSS is not available in React Native, so styling must be applied to elements directly instead of using classNames or other selectors. A good way to ensure that styles are passed through a tree is to use a `ThemeProvider`. More information about our theming can be found [here](https://github.com/microsoft/fluentui-react-native/tree/master/docs/pages/Theming)
14+
CSS is not available in React Native, so styling must be applied to elements directly instead of using classNames or other selectors. A good way to ensure that styles are passed through a tree is to use a `ThemeProvider`. More information about our theming can be found [here](../Theming)

docs/pages/Guides/UpdateThemeProvider.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ We have a deprecated ThemeProvider which takes in a `ThemeRegistry`. The new The
66

77
The new `ThemeProvider` takes in a different object as its value, a `ThemeReference`, so you'll need to convert your `ThemeRegistry` into a `ThemeReference` in order to use the new `ThemeProvider`.
88

9-
If you were using `createPlatformThemeRegistry(<paletteName>)` to create your `ThemeRegistry`, you can get an equivalent `ThemeReference` by calling `createOfficeTheme({ paletteName: <paletteName> })` instead. Details on `createOfficeTheme` can be found [here](https://github.com/microsoft/fluentui-react-native/blob/master/docs/pages/Theming/DefaultThemes.md#integration-with-office).
9+
If you were using `createPlatformThemeRegistry(<paletteName>)` to create your `ThemeRegistry`, you can get an equivalent `ThemeReference` by calling `createOfficeTheme({ paletteName: <paletteName> })` instead. Details on `createOfficeTheme` can be found [here](../Theming/DefaultThemes.md#integration-with-office).
1010

1111
The gist is that what used to be the `ProcessTheme` function passed into the `ThemeRegistry`'s `setTheme` can now be turned into a `ThemeRecipe` passed into the `ThemeReference`. So where a `ThemeRegistry` might have had:
1212

@@ -33,7 +33,7 @@ const themeRef = new ThemeReference(
3333
);
3434
```
3535

36-
`ThemeReferences` can also take advantage of our [default themes](https://github.com/microsoft/fluentui-react-native/blob/master/docs/pages/Theming/DefaultThemes.md). Learn how to create custom themes [here](https://github.com/microsoft/fluentui-react-native/blob/master/docs/pages/Theming/CustomTheme.md).
36+
`ThemeReferences` can also take advantage of our [default themes](../Theming/DefaultThemes.md). Learn how to create custom themes [here](../Theming/CustomTheme.md).
3737

3838
## Importing `ThemeProvider` from the new package
3939

docs/pages/Guides/UpdatingCustomize.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Migrating from old to new customize
22

3-
The customize API allows clients to make targeted styling modifications to our controls. The second version of the FluentUI composition framework changes the customize API. This guide will describe how to move from the first to second customize API for our refreshed controls.
3+
The customize API allows clients to make targeted styling modifications to our controls. The second version of the FluentUI composition framework changes the customize API. This guide will describe how to move from the first to second customize API for our refreshed controls.
44

55
## Old customize
66

@@ -59,7 +59,7 @@ All states that were previously under `_overrides` are now at the top level of t
5959

6060
### No `_precedence` property
6161

62-
There is no equivalent for `_precedence` in the new customize API. If you need this functionality, [please look at using `compose` instead](https://github.com/microsoft/fluentui-react-native/tree/master/packages/framework/composition#compose).
62+
There is no equivalent for `_precedence` in the new customize API. If you need this functionality, [please look at using `compose` instead](../../../packages/framework/composition/README.md#compose).
6363

6464
### No slots as properties
6565

docs/pages/Theming/ColorTokens/Basics.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Global tokens can be imported directly:
1414

1515
`import { globalTokens } from '@fluentui-react-native\theme-tokens'`
1616

17-
If accessing a specific color, you can find it in the `globalTokens.color` property. The token object can be found [here](https://github.com/microsoft/fluentui-react-native/blob/master/packages/theming/theme-tokens/src/generated/global/reactnative/tokens-global.json) or [here for win32](https://github.com/microsoft/fluentui-react-native/blob/master/packages/theming/theme-tokens/src/generated/global-win32/reactnative/tokens-global.json).
17+
If accessing a specific color, you can find it in the `globalTokens.color` property. The token object can be found [here](../../../../packages/theming/theme-tokens/src/generated/global/reactnative/tokens-global.json) or [here for win32](../../../../packages/theming/theme-tokens/src/generated/global-win32/reactnative/tokens-global.json).
1818

1919
An example of usage is in our PersonaCoin, where we use colors for the coin background if an image is not used.
2020

docs/pages/Theming/ColorTokens/UsageWithComponentTokens.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const Foo = compose<TabItemType>({
4949
export default Foo;
5050
```
5151

52-
Our [Tab control](https://github.com/microsoft/fluentui-react-native/blob/master/packages/experimental/Tabs/src/TabsItemTokens.ts) uses this system to integrate alias tokens.
52+
Our [Tab control](../../../../packages/experimental/Tabs/src/TabsItemTokens.ts) uses this system to integrate alias tokens.
5353

5454
## Using useTokens hook
5555

@@ -75,4 +75,4 @@ export const Component = (props: TProps) => {
7575
};
7676
```
7777

78-
This hook is what the `compose` framework uses to create style tokens based on the current theme. You can read more on `useTokens` [here](https://github.com/microsoft/fluentui-react-native/tree/master/packages/framework/use-tokens).
78+
This hook is what the `compose` framework uses to create style tokens based on the current theme. You can read more on `useTokens` [here](../../../../packages/framework/use-tokens/README.md).

docs/pages/Theming/DefaultThemes.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const AppContent = () => {
4646
};
4747
```
4848

49-
You can take a look at how the palette is used to populate theme colors [here](https://github.com/microsoft/fluentui-react-native/blob/master/packages/theming/win32-theme/src/paletteFromOfficeColors.ts) and [here](https://github.com/microsoft/fluentui-react-native/blob/master/packages/theming/win32-theme/src/createAliasesFromPalette.ts).
49+
You can take a look at how the palette is used to populate theme colors [here](../../../packages/theming/win32-theme/src/paletteFromOfficeColors.ts) and [here](../../../packages/theming/win32-theme/src/createAliasesFromPalette.ts).
5050

5151
## Example
5252

docs/pages/Theming/ThemedStylesheet.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ export const Component = () => {
4343

4444
## Additional Reading
4545

46-
For more detailed information, check out [our README](https://github.com/microsoft/fluentui-react-native/blob/master/packages/framework/themed-stylesheet/README.md).
46+
For more detailed information, check out [our README](../../../packages/framework/themed-stylesheet/README.md).

0 commit comments

Comments
 (0)