feat(react-table): Add toggleSomeRows selection state #35291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-some-rows-selection-state
dmytrokirpa
reviewed
Oct 20, 2025
There was a problem hiding this comment.
Thank you for the PR. I have a few comments:
- We likely don't need to modify the
useSelectionhook, as the component hook doesn't appear to use the new method. - I'm not sure this change is necessary, since it can be worked around with
toggleAllRowsortoggleRow, but I'll let the core maintainers @microsoft/teams-prg make the final decision.
| }); | ||
|
|
||
| const toggleSomeRows: TableSelectionState['toggleSomeRows'] = useEventCallback((e, rowIds: Set<TableRowId>) => { | ||
| selectionMethods.toggleAllItems( |
There was a problem hiding this comment.
If toggleAllItems could be used here, why do we need to add the used toggleSomeItems method to the useSelection hook?
There was a problem hiding this comment.
This was overlooked, updated to use toggleSomeItems.
…le-some-rows-selection-state
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
There was no simple way to toggle a subset of rows, only a single row (
toggleRow) or all rows (toggleAllRows).New Behavior
This PR adds
toggleSomeRows, allowing specific rows to be toggled for more flexible selection.