-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headed browser sessions aren't cleaned up #1268
Comments
Issue Title: Headed browser sessions aren't cleaned up Issue Body: const page = await host.browse(
"https://microsoft.github.io/genaiscript/reference/scripts/browser/",
{
headless: false,
browser: "firefox",
}
); Each time you run the script, it creates a new browser session without cleaning up previous sessions. This makes it difficult to manage multiple browsing contexts and can lead to resource exhaustion. For Firefox, quitting a browser session by using Cmd+Q does not properly close all associated processes, which necessitates Force Quitting. ![]() Please clarify if the issue is specific to Firefox or also affects Chromium. Additionally, could you provide information on how other browsers handle this scenario?
|
Try setting incognito to false to reuse the sessions. |
I will text this because there is code in place to close all pages, contexts and browsers. |
It doesn't seem to work for some reason. |
@volkanunsal what os are you using? |
This should fix it> #1274 |
Still seeing this issue with 1.114.4. |
What OS are you running? |
do you run the script through the cli or vscode? |
I'm running on Mac. I ran it from VSCode. |
Ha I think I only run the cleaning out when I shut down the host. |
SummaryUsers are encountering issues where browser sessions, specifically Firefox and Chromium, are not being properly cleaned up after each script execution in Current efforts to fix the issue include setting the
|
I'm noticing this issue with several browsers. To replicate:
Each time you run the script, it creates a new browser session.
What makes this worse is Chromium session cannot be quit with Cmd+Q. You have to Force Quit it. That's why I chose to use Firefox.
The text was updated successfully, but these errors were encountered: