Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Where op for bool input #24127

Open
wenlonn opened this issue Mar 21, 2025 · 2 comments
Open

[Feature Request] Where op for bool input #24127

wenlonn opened this issue Mar 21, 2025 · 2 comments
Labels
feature request request for unsupported feature or enhancement

Comments

@wenlonn
Copy link

wenlonn commented Mar 21, 2025

Describe the feature request

support where op with bool inputs

Describe scenario use case

For where op, there is a situation that the X/Y/output is bool type. We try to infer model with this where op, and got an error, which claims that where(9) NOT_IMPLEMNTED. We revise the code and add the declare of bool type where, test the wheel with python. Please support where op with bool inputs in version 1.15.1 +

@wenlonn wenlonn added the feature request request for unsupported feature or enhancement label Mar 21, 2025
@wenlonn
Copy link
Author

wenlonn commented Mar 21, 2025

Until now, we find two method to solve this issue, however it costs a lot.

First one, as where op only support float/int type for now, we propose to insert cast_op before the input of where and after the output of where. By the way the op index of inserted cast_op may need to be arranged.
Second one, add bool type where op implement in source code, then compile and install wheel in python. However, we need to maintain the wheel package in our program.

@xadupre
Copy link
Member

xadupre commented Mar 21, 2025

Since you did the modification to support bool, could you submit a PR?

@tianleiwu tianleiwu changed the title [Feature Request] [Feature Request] Where op for bool input Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for unsupported feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants