virt_mshv_vtl, snp: Add more automatic exits to boot the debug build (#1324)

On the hardware I have that debug assert fires for the automatic exit
that's not in the match statement.

Update the match list to be able to boot the debug build on the newer
hardware.

While at it, convert the exit codes to hex like in the AMD PPR, add
additional codes for easier debugging,
and panic on the negative exit codes that are not covered by the match
statement.

Author: romank-msft

openhcl/virt_mshv_vtl/src/processor/snp/mod.rs

@@ -113,7 +113,6 @@ struct ExitStats {
     npf_no_intercept: Counter,
     npf_spurious: Counter,
     rdpmc: Counter,
-    unexpected: Counter,
     vmgexit: Counter,
     vmmcall: Counter,
     xsetbv: Counter,
@@ -1471,7 +1470,12 @@ impl UhProcessor<'_, SnpBacked> {
                 &mut self.backing.exit_stats[entered_from_vtl].vmgexit
             }
 
-            SevExitCode::NMI | SevExitCode::PAUSE | SevExitCode::SMI | SevExitCode::VMGEXIT => {
+            SevExitCode::NMI
+            | SevExitCode::PAUSE
+            | SevExitCode::SMI
+            | SevExitCode::VMGEXIT
+            | SevExitCode::BUSLOCK
+            | SevExitCode::IDLE_HLT => {
                 // Ignore intercept processing if the guest exited due to an automatic exit.
                 &mut self.backing.exit_stats[entered_from_vtl].automatic_exit
             }
@@ -1533,12 +1537,17 @@ impl UhProcessor<'_, SnpBacked> {
             }
 
             _ => {
-                debug_assert!(
-                    false,
-                    "Received unexpected exit code {}",
-                    vmsa.guest_error_code()
+                // Don't print too much of the register state, might have guest secrets
+                // parts thereof.
+                tracing::error!(
+                    "SEV exit code {sev_error_code:x?}, rip {:x?}, next rip {:x?}, sev features {:x?}, v_intr_control {:x?}, event inject {:x?}",
+                    vmsa.rip(),
+                    vmsa.next_rip(),
+                    vmsa.sev_features(),
+                    vmsa.v_intr_cntrl(),
+                    vmsa.event_inject(),
                 );
-                &mut self.backing.exit_stats[entered_from_vtl].unexpected
+                panic!("Received unexpected SEV exit code {sev_error_code:x?}");
             }
         };
         stat.increment();

vm/x86/x86defs/src/snp.rs

@@ -469,159 +469,187 @@ pub const GHCB_PAGE_HYPERCALL_OUTPUT_OFFSET: usize = 4080;
 // Exit Codes.
 open_enum::open_enum! {
     pub enum SevExitCode: u64 {
-        CR0_READ = 0,
-        CR1_READ = 1,
-        CR2_READ = 2,
-        CR3_READ = 3,
-        CR4_READ = 4,
-        CR5_READ = 5,
-        CR6_READ = 6,
-        CR7_READ = 7,
-        CR8_READ = 8,
-        CR9_READ = 9,
-        CR10_READ = 10,
-        CR11_READ = 11,
-        CR12_READ = 12,
-        CR13_READ = 13,
-        CR14_READ = 14,
-        CR15_READ = 15,
-        CR0_WRITE = 16,
-        CR1_WRITE = 17,
-        CR2_WRITE = 18,
-        CR3_WRITE = 19,
-        CR4_WRITE = 20,
-        CR5_WRITE = 21,
-        CR6_WRITE = 22,
-        CR7_WRITE = 23,
-        CR8_WRITE = 24,
-        CR9_WRITE = 25,
-        CR10_WRITE = 26,
-        CR11_WRITE = 27,
-        CR12_WRITE = 28,
-        CR13_WRITE = 29,
-        CR14_WRITE = 30,
-        CR15_WRITE = 31,
-        DR0_READ = 32,
-        DR1_READ = 33,
-        DR2_READ = 34,
-        DR3_READ = 35,
-        DR4_READ = 36,
-        DR5_READ = 37,
-        DR6_READ = 38,
-        DR7_READ = 39,
-        DR8_READ = 40,
-        DR9_READ = 41,
-        DR10_READ = 42,
-        DR11_READ = 43,
-        DR12_READ = 44,
-        DR13_READ = 45,
-        DR14_READ = 46,
-        DR15_READ = 47,
-        DR0_WRITE = 48,
-        DR1_WRITE = 49,
-        DR2_WRITE = 50,
-        DR3_WRITE = 51,
-        DR4_WRITE = 52,
-        DR5_WRITE = 53,
-        DR6_WRITE = 54,
-        DR7_WRITE = 55,
-        DR8_WRITE = 56,
-        DR9_WRITE = 57,
-        DR10_WRITE = 58,
-        DR11_WRITE = 59,
-        DR12_WRITE = 60,
-        DR13_WRITE = 61,
-        DR14_WRITE = 62,
-        DR15_WRITE = 63,
-        EXCP0 = 64,
-        EXCP_DB = 65,
-        EXCP2 = 66,
-        EXCP3 = 67,
-        EXCP4 = 68,
-        EXCP5 = 69,
-        EXCP6 = 70,
-        EXCP7 = 71,
-        EXCP8 = 72,
-        EXCP9 = 73,
-        EXCP10 = 74,
-        EXCP11 = 75,
-        EXCP12 = 76,
-        EXCP13 = 77,
-        EXCP14 = 78,
-        EXCP15 = 79,
-        EXCP16 = 80,
-        EXCP17 = 81,
-        EXCP18 = 82,
-        EXCP19 = 83,
-        EXCP20 = 84,
-        EXCP21 = 85,
-        EXCP22 = 86,
-        EXCP23 = 87,
-        EXCP24 = 88,
-        EXCP25 = 89,
-        EXCP26 = 90,
-        EXCP27 = 91,
-        EXCP28 = 92,
-        EXCP29 = 93,
-        EXCP30 = 94,
-        EXCP31 = 95,
-        INTR = 96,
-        NMI = 97,
-        SMI = 98,
-        INIT = 99,
-        VINTR = 100,
-        CR0_SEL_WRITE = 101,
-        IDTR_READ = 102,
-        GDTR_READ = 103,
-        LDTR_READ = 104,
-        TR_READ = 105,
-        IDTR_WRITE = 106,
-        GDTR_WRITE = 107,
-        LDTR_WRITE = 108,
-        TR_WRITE = 109,
-        RDTSC = 110,
-        RDPMC = 111,
-        PUSHF = 112,
-        POPF = 113,
-        CPUID = 114,
-        RSM = 115,
-        IRET = 116,
-        SWINT = 117,
-        INVD = 118,
-        PAUSE = 119,
-        HLT = 120,
-        INVLPG = 121,
-        INVLPGA = 122,
-        IOIO = 123,
-        MSR = 124,
-        TASK_SWITCH = 125,
-        FERR_FREEZE = 126,
-        SHUTDOWN = 127,
-        VMRUN = 128,
-        VMMCALL = 129,
-        VMLOAD = 130,
-        VMSAVE = 131,
-        STGI = 132,
-        CLGI = 133,
-        SKINIT = 134,
-        RDTSCP = 135,
-        ICEBP = 136,
-        WBINVD = 137,
-        MONITOR = 138,
-        MWAIT = 139,
-        MWAIT_CONDITIONAL = 140,
-        XSETBV = 141,
-        INVLPGB = 160,
-        ILLEGAL_INVLPGB = 161,
-        NPF = 1024,
-        AVIC_INCOMPLETE_IPI = 1025,
-        AVIC_NOACCEL = 1026,
-        VMGEXIT = 1027,
-        PAGE_NOT_VALIDATED = 1028,
+        CR0_READ = 0x0,
+        CR1_READ = 0x1,
+        CR2_READ = 0x2,
+        CR3_READ = 0x3,
+        CR4_READ = 0x4,
+        CR5_READ = 0x5,
+        CR6_READ = 0x6,
+        CR7_READ = 0x7,
+        CR8_READ = 0x8,
+        CR9_READ = 0x9,
+        CR10_READ = 0xa,
+        CR11_READ = 0xb,
+        CR12_READ = 0xc,
+        CR13_READ = 0xd,
+        CR14_READ = 0xe,
+        CR15_READ = 0xf,
+        CR0_WRITE = 0x10,
+        CR1_WRITE = 0x11,
+        CR2_WRITE = 0x12,
+        CR3_WRITE = 0x13,
+        CR4_WRITE = 0x14,
+        CR5_WRITE = 0x15,
+        CR6_WRITE = 0x16,
+        CR7_WRITE = 0x17,
+        CR8_WRITE = 0x18,
+        CR9_WRITE = 0x19,
+        CR10_WRITE = 0x1a,
+        CR11_WRITE = 0x1b,
+        CR12_WRITE = 0x1c,
+        CR13_WRITE = 0x1d,
+        CR14_WRITE = 0x1e,
+        CR15_WRITE = 0x1f,
+        DR0_READ = 0x20,
+        DR1_READ = 0x21,
+        DR2_READ = 0x22,
+        DR3_READ = 0x23,
+        DR4_READ = 0x24,
+        DR5_READ = 0x25,
+        DR6_READ = 0x26,
+        DR7_READ = 0x27,
+        DR8_READ = 0x28,
+        DR9_READ = 0x29,
+        DR10_READ = 0x2a,
+        DR11_READ = 0x2b,
+        DR12_READ = 0x2c,
+        DR13_READ = 0x2d,
+        DR14_READ = 0x2e,
+        DR15_READ = 0x2f,
+        DR0_WRITE = 0x30,
+        DR1_WRITE = 0x31,
+        DR2_WRITE = 0x32,
+        DR3_WRITE = 0x33,
+        DR4_WRITE = 0x34,
+        DR5_WRITE = 0x35,
+        DR6_WRITE = 0x36,
+        DR7_WRITE = 0x37,
+        DR8_WRITE = 0x38,
+        DR9_WRITE = 0x39,
+        DR10_WRITE = 0x3a,
+        DR11_WRITE = 0x3b,
+        DR12_WRITE = 0x3c,
+        DR13_WRITE = 0x3d,
+        DR14_WRITE = 0x3e,
+        DR15_WRITE = 0x3f,
+        EXCP0 = 0x40,
+        EXCP_DB = 0x41,
+        EXCP2 = 0x42,
+        EXCP3 = 0x43,
+        EXCP4 = 0x44,
+        EXCP5 = 0x45,
+        EXCP6 = 0x46,
+        EXCP7 = 0x47,
+        EXCP8 = 0x48,
+        EXCP9 = 0x49,
+        EXCP10 = 0x4a,
+        EXCP11 = 0x4b,
+        EXCP12 = 0x4c,
+        EXCP13 = 0x4d,
+        EXCP14 = 0x4e,
+        EXCP15 = 0x4f,
+        EXCP16 = 0x50,
+        EXCP17 = 0x51,
+        EXCP18 = 0x52,
+        EXCP19 = 0x53,
+        EXCP20 = 0x54,
+        EXCP21 = 0x55,
+        EXCP22 = 0x56,
+        EXCP23 = 0x57,
+        EXCP24 = 0x58,
+        EXCP25 = 0x59,
+        EXCP26 = 0x5a,
+        EXCP27 = 0x5b,
+        EXCP28 = 0x5c,
+        EXCP29 = 0x5d,
+        EXCP30 = 0x5e,
+        EXCP31 = 0x5f,
+        INTR = 0x60,
+        NMI = 0x61,
+        SMI = 0x62,
+        INIT = 0x63,
+        VINTR = 0x64,
+        CR0_SEL_WRITE = 0x65,
+        IDTR_READ = 0x66,
+        GDTR_READ = 0x67,
+        LDTR_READ = 0x68,
+        TR_READ = 0x69,
+        IDTR_WRITE = 0x6a,
+        GDTR_WRITE = 0x6b,
+        LDTR_WRITE = 0x6c,
+        TR_WRITE = 0x6d,
+        RDTSC = 0x6e,
+        RDPMC = 0x6f,
+        PUSHF = 0x70,
+        POPF = 0x71,
+        CPUID = 0x72,
+        RSM = 0x73,
+        IRET = 0x74,
+        SWINT = 0x75,
+        INVD = 0x76,
+        PAUSE = 0x77,
+        HLT = 0x78,
+        INVLPG = 0x79,
+        INVLPGA = 0x7a,
+        IOIO = 0x7b,
+        MSR = 0x7c,
+        TASK_SWITCH = 0x7d,
+        FERR_FREEZE = 0x7e,
+        SHUTDOWN = 0x7f,
+        VMRUN = 0x80,
+        VMMCALL = 0x81,
+        VMLOAD = 0x82,
+        VMSAVE = 0x83,
+        STGI = 0x84,
+        CLGI = 0x85,
+        SKINIT = 0x86,
+        RDTSCP = 0x87,
+        ICEBP = 0x88,
+        WBINVD = 0x89,
+        MONITOR = 0x8a,
+        MWAIT = 0x8b,
+        MWAIT_CONDITIONAL = 0x8c,
+        XSETBV = 0x8d,
+        RDPRU = 0x8e,
+        EFER_WRITE_TRAP = 0x8f,
+        CR0_WRITE_TRAP = 0x90,
+        CR1_WRITE_TRAP = 0x91,
+        CR2_WRITE_TRAP = 0x92,
+        CR3_WRITE_TRAP = 0x93,
+        CR4_WRITE_TRAP = 0x94,
+        CR5_WRITE_TRAP = 0x95,
+        CR6_WRITE_TRAP = 0x96,
+        CR7_WRITE_TRAP = 0x97,
+        CR8_WRITE_TRAP = 0x98,
+        CR9_WRITE_TRAP = 0x99,
+        CR10_WRITE_TRAP = 0x9a,
+        CR11_WRITE_TRAP = 0x9b,
+        CR12_WRITE_TRAP = 0x9c,
+        CR13_WRITE_TRAP = 0x9d,
+        CR14_WRITE_TRAP = 0x9e,
+        CR15_WRITE_TRAP = 0x9f,
+        INVLPGB = 0xa0,
+        ILLEGAL_INVLPGB = 0xa1,
+        INVPCID = 0xa2,
+        BUSLOCK = 0xa5,
+        IDLE_HLT = 0xa6,
+        NPF = 0x400,
+        AVIC_INCOMPLETE_IPI = 0x401,
+        AVIC_NOACCEL = 0x402,
+        VMGEXIT = 0x403,
+        PAGE_NOT_VALIDATED = 0x404,
+
+        // SEV-ES software-defined exit codes
         SNP_GUEST_REQUEST = 0x80000011,
         SNP_EXTENDED_GUEST_REQUEST = 0x80000012,
         HV_DOORBELL_PAGE = 0x80000014,
+
+        // SEV-SNP hardware error codes
         INVALID_VMCB = 0xffff_ffff_ffff_ffff,
+        VMSA_BUSY = 0xffff_ffff_ffff_fffe,
+        IDLE_REQUIRED = 0xffff_ffff_ffff_fffd,
+        INVALID_PMC = 0xffff_ffff_ffff_fffc,
     }
 }