Fix two issues that cause the latest Clippy to fail the build. #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary conversion picked up by the latest Clippy in convert.rs Switch to use .is_none_or instead of .map_or in ast_context.rs. Fixes microsoft#2256
absoludity
commented
Mar 28, 2025
|
@microsoft-github-policy-service agree |
absoludity
requested review from
billti,
idavis,
minestarks,
ScottCarda-MS and
swernli
as code owners
absoludity
changed the title
swernli
approved these changes
Apr 4, 2025
billti
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary conversion picked up by the latest Clippy in convert.rs
Switch to use .is_none_or instead of .map_or in ast_context.rs.
Fixes #2256