Skip to content

Binop errors should be able to use span for entire expression #2581

@swernli

Description

@swernli

Right now, any error in a binary operation expression during evaluation always uses the span for the right-hand side, as that's the only span passed through. But for some errors it makes more sense to highlight the left-hand side or the entire expression. We should update the parameters for the binop helpers to accept multiple spans so the individual error cases can choose the most appropriate one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingerror messagesimprove feedback from error messageslow-prioritybacklog items with low priorityneeds triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions