Suppress no-console rule violations.

Author: iclanton

Diff for: apps/api-documenter/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node-trusted-tool', 'eslint-config-local/mixins/friendly-locals'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: apps/api-extractor/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node-trusted-tool', 'eslint-config-local/mixins/friendly-locals'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: apps/heft/src/startWithVersionSelector.ts

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
+/* eslint-disable no-console */
+
 // NOTE: Since startWithVersionSelector.ts is loaded in the same process as start.ts, any dependencies that
 // we import here may become side-by-side versions.  We want to minimize any dependencies.
 import * as path from 'path';

Diff for: apps/lockfile-explorer-web/src/App.tsx

@@ -26,6 +26,7 @@ export const App = (): JSX.Element => {
       dispatch(loadEntries(lockfile));
     }
     loadLockfileAsync().catch((e) => {
+      // eslint-disable-next-line no-console
       console.log(`Failed to read lockfile: ${e}`);
     });
   }, []);

Diff for: apps/lockfile-explorer-web/src/components/ConnectionModal/index.tsx

@@ -31,6 +31,7 @@ export const ConnectionModal = (): JSX.Element | ReactNull => {
     setManualChecked(true);
     keepAliveAsync().catch((e) => {
       // Keep alive cannot fail
+      // eslint-disable-next-line no-console
       console.error(`Unexpected exception: ${e}`);
     });
   }, []);

Diff for: apps/lockfile-explorer-web/src/containers/LockfileEntryDetailsView/index.tsx

@@ -57,6 +57,7 @@ export const LockfileEntryDetailsView = (): JSX.Element | ReactNull => {
     }
 
     loadPackageJson(selectedEntry?.referrers || []).catch((e) => {
+      // eslint-disable-next-line no-console
       console.error(`Failed to load referrers package.json: ${e}`);
     });
     if (selectedEntry) {
@@ -73,6 +74,7 @@ export const LockfileEntryDetailsView = (): JSX.Element | ReactNull => {
           logDiagnosticInfo('No resolved entry for dependency:', dependencyToTrace);
         }
       } else if (selectedEntry) {
+        // eslint-disable-next-line no-console
         console.log('dependency to trace: ', dependencyToTrace);
         setInspectDependency(dependencyToTrace);
 
@@ -110,6 +112,7 @@ export const LockfileEntryDetailsView = (): JSX.Element | ReactNull => {
                   // YAML file.  If not, either something is wrong with our algorithm, or else
                   // something has changed about how PNPM manages its "transitivePeerDependencies"
                   // field.
+                  // eslint-disable-next-line no-console
                   console.error(
                     'Error analyzing influencers: A referrer appears to be missing its "transitivePeerDependencies" field in the YAML file: ',
                     dependencyToTrace,

Diff for: apps/lockfile-explorer-web/src/containers/PackageJsonViewer/index.tsx

@@ -41,6 +41,7 @@ export const PackageJsonViewer = (): JSX.Element => {
       setPnpmfile(pnpmfile);
     }
     loadPnpmFileAsync().catch((e) => {
+      // eslint-disable-next-line no-console
       console.error(`Failed to load project's pnpm file: ${e}`);
     });
   }, []);
@@ -60,10 +61,12 @@ export const PackageJsonViewer = (): JSX.Element => {
     if (selectedEntry) {
       if (selectedEntry.entryPackageName) {
         loadPackageDetailsAsync(selectedEntry.packageJsonFolderPath).catch((e) => {
+          // eslint-disable-next-line no-console
           console.error(`Failed to load project information: ${e}`);
         });
       } else {
         // This is used to develop the lockfile explorer application in case there is a mistake in our logic
+        // eslint-disable-next-line no-console
         console.log('The selected entry has no entry name: ', selectedEntry.entryPackageName);
       }
     }

Diff for: apps/lockfile-explorer-web/src/helpers/logDiagnosticInfo.ts

@@ -5,6 +5,7 @@
 // problems with the algorithm.
 export const logDiagnosticInfo = (...args: string[]): void => {
   if (window.appContext.debugMode) {
+    // eslint-disable-next-line no-console
     console.log('Diagnostic: ', ...args);
   }
 };

Diff for: apps/lockfile-explorer-web/src/parsing/LockfileDependency.ts

@@ -71,6 +71,7 @@ export class LockfileDependency {
         new Path(containingEntry.packageJsonFolderPath).concat(relativePath)
       );
       if (!rootRelativePath) {
+        // eslint-disable-next-line no-console
         console.error('No root relative path for dependency!', name);
         return;
       }
@@ -89,6 +90,7 @@ export class LockfileDependency {
         };
         this.entryId = 'Peer: ' + this.name;
       } else {
+        // eslint-disable-next-line no-console
         console.error('Peer dependencies info missing!', node);
       }
     } else {

Diff for: apps/lockfile-explorer-web/src/parsing/LockfileEntry.ts

@@ -79,6 +79,7 @@ export class LockfileEntry {
       const packageName = new Path(rawEntryId).basename();
 
       if (!packageJsonFolderPath || !packageName) {
+        // eslint-disable-next-line no-console
         console.error('Could not construct path for entry: ', rawEntryId);
         return;
       }

Diff for: apps/lockfile-explorer-web/src/parsing/getPackageFiles.ts

@@ -24,6 +24,7 @@ export async function readPnpmfileAsync(): Promise<string> {
     const response = await fetch(`${apiPath}/pnpmfile`);
     return await response.text();
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error('Could not load cjs file: ', e);
     return 'Missing CJS';
   }
@@ -42,6 +43,7 @@ export async function readPackageJsonAsync(projectPath: string): Promise<IPackag
     });
     return await response.json();
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error('Could not load package json file: ', e);
     return undefined;
   }
@@ -60,6 +62,7 @@ export async function readPackageSpecAsync(projectPath: string): Promise<IPackag
     });
     return await response.json();
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error('Could not load cjs file: ', e);
     return undefined;
   }

Diff for: apps/lockfile-explorer-web/src/parsing/readLockfile.ts

@@ -182,6 +182,7 @@ export function generateLockfileGraph(lockfile: ILockfilePackageType): LockfileE
         matchedEntry.referrers.push(entry);
       } else {
         // Local package
+        // eslint-disable-next-line no-console
         console.error('Could not resolve dependency entryId: ', dependency.entryId, dependency);
       }
     }

Diff for: apps/lockfile-explorer-web/src/stub/initappcontext.ts

@@ -5,6 +5,7 @@
 // from Webpack dev server.  In a production release, a generated script is served by the
 // Node.js service with the live context object.
 
+// eslint-disable-next-line no-console
 console.log('Loaded stub/initappcontext.js');
 
 window.appContext = {

Diff for: apps/lockfile-explorer/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: apps/rundown/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node-trusted-tool', 'eslint-config-local/mixins/friendly-locals'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: apps/rush/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node-trusted-tool', 'eslint-config-local/mixins/friendly-locals'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: apps/trace-import/.eslintrc.js

@@ -3,5 +3,14 @@ require('eslint-config-local/patch/modern-module-resolution');
 
 module.exports = {
   extends: ['eslint-config-local/profile/node-trusted-tool', 'eslint-config-local/mixins/friendly-locals'],
-  parserOptions: { tsconfigRootDir: __dirname }
+  parserOptions: { tsconfigRootDir: __dirname },
+
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-console': 'off'
+      }
+    }
+  ]
 };

Diff for: build-tests-samples/heft-node-jest-tutorial/src/guide/02-manual-mock/SoundPlayer.ts

@@ -12,7 +12,9 @@ export class SoundPlayer {
   }
 
   public playSoundFile(fileName: string): void {
+    // eslint-disable-next-line no-console
     console.log('Playing sound file ' + fileName);
+    // eslint-disable-next-line no-console
     console.log('Foo=' + this._foo);
   }
 }

Diff for: build-tests-samples/heft-node-jest-tutorial/src/guide/SoundPlayer.ts

@@ -12,7 +12,9 @@ export class SoundPlayer {
   }
 
   public playSoundFile(fileName: string): void {
+    // eslint-disable-next-line no-console
     console.log('Playing sound file ' + fileName);
+    // eslint-disable-next-line no-console
     console.log('Foo=' + this._foo);
   }
 }

Diff for: build-tests-samples/heft-storybook-react-tutorial/src/ExampleApp.tsx

@@ -31,6 +31,7 @@ export class ExampleApp extends React.Component {
   // is bound correctly.  This form does not work with virtual/override inheritance, so use regular methods
   // everywhere else.
   private _onToggle = (sender: ToggleSwitch, args: IToggleEventArgs): void => {
+    // eslint-disable-next-line no-console
     console.log('Toggle switch changed: ' + args.sliderPosition);
   };
 }

Diff for: build-tests-samples/heft-web-rig-app-tutorial/src/ExampleApp.tsx

@@ -33,6 +33,7 @@ export class ExampleApp extends React.Component {
   // is bound correctly.  This form does not work with virtual/override inheritance, so use regular methods
   // everywhere else.
   private _onToggle = (sender: ToggleSwitch, args: IToggleEventArgs): void => {
+    // eslint-disable-next-line no-console
     console.log('Toggle switch changed: ' + args.sliderPosition);
   };
 }

Diff for: build-tests-samples/heft-webpack-basic-tutorial/src/ExampleApp.tsx

@@ -31,6 +31,7 @@ export class ExampleApp extends React.Component {
   // is bound correctly.  This form does not work with virtual/override inheritance, so use regular methods
   // everywhere else.
   private _onToggle = (sender: ToggleSwitch, args: IToggleEventArgs): void => {
+    // eslint-disable-next-line no-console
     console.log('Toggle switch changed: ' + args.sliderPosition);
   };
 }

Diff for: build-tests/heft-fastify-test/src/start.ts

@@ -3,17 +3,22 @@
 
 import { fastify, type FastifyInstance } from 'fastify';
 
+// eslint-disable-next-line no-console
 console.error('CHILD STARTING');
 process.on('beforeExit', () => {
+  // eslint-disable-next-line no-console
   console.error('CHILD BEFOREEXIT');
 });
 process.on('exit', () => {
+  // eslint-disable-next-line no-console
   console.error('CHILD EXITED');
 });
 process.on('SIGINT', function () {
+  // eslint-disable-next-line no-console
   console.error('CHILD SIGINT');
 });
 process.on('SIGTERM', function () {
+  // eslint-disable-next-line no-console
   console.error('CHILD SIGTERM');
 });
 
@@ -31,6 +36,7 @@ class MyApp {
       return { hello: 'world' };
     });
 
+    // eslint-disable-next-line no-console
     console.log('Listening on http://localhost:3000');
     await this.server.listen(3000);
   }
@@ -41,9 +47,12 @@ class MyApp {
       this.server.log.error(error);
 
       if (error.stack) {
+        // eslint-disable-next-line no-console
         console.error(error.stack);
+        // eslint-disable-next-line no-console
         console.error();
       }
+      // eslint-disable-next-line no-console
       console.error('ERROR: ' + error.toString());
     });
   }

Diff for: build-tests/heft-jest-reporters-test/src/test/customJestReporter.ts

@@ -15,22 +15,28 @@ module.exports = class CustomJestReporter implements Reporter {
   public constructor(globalConfig: Config.GlobalConfig, options: unknown) {}
 
   public onRunStart(results: AggregatedResult, options: ReporterOnStartOptions): void | Promise<void> {
+    // eslint-disable-next-line no-console
     console.log();
+    // eslint-disable-next-line no-console
     console.log(`################# Custom Jest reporter: Starting test run #################`);
   }
 
   public onTestStart(test: Test): void | Promise<void> {}
 
   public onTestResult(test: Test, testResult: TestResult, results: AggregatedResult): void | Promise<void> {
+    // eslint-disable-next-line no-console
     console.log('Custom Jest reporter: Reporting test result');
 
     for (const result of testResult.testResults) {
+      // eslint-disable-next-line no-console
       console.log(`${result.title}: ${result.status}`);
     }
   }
 
   public onRunComplete(contexts: Set<TestContext>, results: AggregatedResult): void | Promise<void> {
+    // eslint-disable-next-line no-console
     console.log('################# Completing test run #################');
+    // eslint-disable-next-line no-console
     console.log();
   }
 

Diff for: build-tests/heft-typescript-composite-test/src/chunks/ChunkClass.ts

@@ -3,6 +3,7 @@
 
 export class ChunkClass {
   public doStuff(): void {
+    // eslint-disable-next-line no-console
     console.log('CHUNK');
   }
 

Diff for: build-tests/heft-typescript-composite-test/src/indexB.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
+// eslint-disable-next-line no-console
 console.log('dostuff');
 
 export {};

Diff for: build-tests/heft-webpack4-everything-test/src/chunks/ChunkClass.ts

@@ -3,6 +3,7 @@
 
 export class ChunkClass {
   public doStuff(): void {
+    // eslint-disable-next-line no-console
     console.log('CHUNK');
   }
 

Diff for: build-tests/heft-webpack4-everything-test/src/indexB.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
+// eslint-disable-next-line no-console
 console.log('dostuff');
 
 export {};

Diff for: build-tests/heft-webpack5-everything-test/src/chunks/ChunkClass.ts

@@ -3,6 +3,7 @@
 
 export class ChunkClass {
   public doStuff(): void {
+    // eslint-disable-next-line no-console
     console.log('CHUNK');
   }