Skip to content

Add Workflow to check if we break snmalloc-rs #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjp41 opened this issue Feb 5, 2025 · 4 comments
Open

Add Workflow to check if we break snmalloc-rs #742

mjp41 opened this issue Feb 5, 2025 · 4 comments

Comments

@mjp41
Copy link
Member

mjp41 commented Feb 5, 2025

Currently the downstream consumer snmalloc-rs is very dependent on the internals of snmalloc. This strong coupling makes release a little awkward. We either need

  • Release process for snmalloc, should have a PR ready to go on snmalloc-rs before we hit complete.
  • Add some workflow jobs that replicate snmalloc-rs CI, and check each PR doesn't break it. (Allow failure, but need to track)
@SchrodingerZhu
Copy link
Collaborator

SchrodingerZhu commented Feb 7, 2025

If needed, as the owner of snmalloc-rs, I am happy to donate the whole repo to upstream and I am willing to do the most work to merge it into microsoft/snmalloc.

The caveat is that we will lose the native FreeBSD CI for rust.

@SchrodingerZhu
Copy link
Collaborator

A PoC in made in #744.

@mjp41
Copy link
Member Author

mjp41 commented Feb 7, 2025

Thanks for doing this. Are you sure about this. You've put a lot of work into snmalloc-rs, and putting it under the Microsoft org, would give you less personal ownership.

I think we should think carefully about the pros and cons of merging it in. I'll try to get the CI functioning, but I propose we leave it a week or two to think about it.

@SchrodingerZhu
Copy link
Collaborator

SchrodingerZhu commented Feb 8, 2025

but I propose we leave it a week or two to think about it.

Good idea. I would also like to collect others' idea

You've put a lot of work into snmalloc-rs, and putting it under the Microsoft org, would give you less personal ownership.

Personally, I think it is okay as long as doing this reduces "unsync" between snmalloc and snmalloc-rs. There is a large amount of downloads of snmalloc-rs so I think to improve its maintainability is of great importance now.

Anyway, let's take time to think about the best way to handle this. Also, another thing I want to do is to sync the version and release cycle between upstream and downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants