Skip to content

Commit 09343d6

Browse files
authored
Rename enablePreviewFeatures configuration option to enableExperimental features and hide the settings flag (#17932)
1 parent d252cbc commit 09343d6

File tree

5 files changed

+4
-13
lines changed

5 files changed

+4
-13
lines changed

localization/xliff/enu/localizedPackage.json.enu.xlf

-3
Original file line numberDiff line numberDiff line change
@@ -425,9 +425,6 @@
425425
<trans-unit id="mssql.objectExplorer.expandTimeout">
426426
<source xml:lang="en">The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.</source>
427427
</trans-unit>
428-
<trans-unit id="mssql.enablePreviewFeaturesDescription">
429-
<source xml:lang="en">Enable preview features in the extension. Requires a restart of VS Code to take effect.</source>
430-
</trans-unit>
431428
<trans-unit id="mssql.newTable">
432429
<source xml:lang="en">New Table</source>
433430
</trans-unit>

package.json

+2-7
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,12 @@
349349
},
350350
{
351351
"command": "mssql.newTable",
352-
"when": "view == objectExplorer && viewItem == TablesFolder && config.mssql.enablePreviewFeatures",
352+
"when": "view == objectExplorer && viewItem == TablesFolder && config.mssql.enableExperimentalFeatures",
353353
"group": "inline"
354354
},
355355
{
356356
"command": "mssql.editTable",
357-
"when": "view == objectExplorer && viewItem == Table && config.mssql.enablePreviewFeatures",
357+
"when": "view == objectExplorer && viewItem == Table && config.mssql.enableExperimentalFeatures",
358358
"group": "inline"
359359
}
360360
],
@@ -673,11 +673,6 @@
673673
"type": "object",
674674
"title": "%mssql.Configuration%",
675675
"properties": {
676-
"mssql.enablePreviewFeatures": {
677-
"type": "boolean",
678-
"default": false,
679-
"description": "%mssql.enablePreviewFeaturesDescription%"
680-
},
681676
"mssql.azureActiveDirectory": {
682677
"type": "string",
683678
"default": "AuthCodeGrant",

package.nls.json

-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@
140140
"mssql.objectExplorer.enableGroupBySchema":"Enable Group By Schema",
141141
"mssql.objectExplorer.disableGroupBySchema":"Disable Group By Schema",
142142
"mssql.objectExplorer.expandTimeout":"The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.",
143-
"mssql.enablePreviewFeaturesDescription":"Enable preview features in the extension. Requires a restart of VS Code to take effect.",
144143
"mssql.newTable":"New Table",
145144
"mssql.editTable":"Edit Table"
146145
}

src/constants/constants.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export const configPersistQueryResultTabs = 'persistQueryResultTabs';
155155
export const configQueryHistoryLimit = 'queryHistoryLimit';
156156
export const configEnableQueryHistoryCapture = 'enableQueryHistoryCapture';
157157
export const configEnableQueryHistoryFeature = 'enableQueryHistoryFeature';
158-
export const configEnablePreviewFeatures = 'enablePreviewFeatures';
158+
export const configEnableExperimentalFeatures = 'enableExperimentalFeatures';
159159

160160
// ToolsService Constants
161161
export const serviceInstallingTo = 'Installing SQL tools service to';

src/controllers/mainController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export default class MainController implements vscode.Disposable {
125125
}
126126

127127
public get isPreviewEnabled(): boolean {
128-
return this.configuration.get(Constants.configEnablePreviewFeatures);
128+
return this.configuration.get(Constants.configEnableExperimentalFeatures);
129129
}
130130

131131
/**

0 commit comments

Comments
 (0)