pr comments & cleanup

Author: cssuh

src/reactviews/media/table.css

@@ -61,46 +61,31 @@
     flex: 0 0 auto;
 }
 
-.slick-header-sort-button {
+.slick-header-sort-button,
+.slick-header-sortdesc-button,
+.slick-header-sortasc-button {
     background-position: center center;
     background-repeat: no-repeat;
     cursor: pointer;
     display: inline-block;
     width: 16px;
-    background-image: url("sort_inverse.svg");
     flex: 0 0 auto;
     margin-right: 2px;
     background-color: transparent;
-    border: 0px;
-    padding: 0px;
+    border: 0;
+    padding: 0;
+}
+
+.slick-header-sort-button {
+    background-image: url("sort_inverse.svg");
 }
 
 .slick-header-sortdesc-button {
-    background-position: center center;
-    background-repeat: no-repeat;
-    cursor: pointer;
-    display: inline-block;
-    width: 16px;
     background-image: url("sort_desc_inverse.svg");
-    flex: 0 0 auto;
-    margin-right: 2px;
-    background-color: transparent;
-    border: 0px;
-    padding: 0px;
 }
 
 .slick-header-sortasc-button {
-    background-position: center center;
-    background-repeat: no-repeat;
-    cursor: pointer;
-    display: inline-block;
-    width: 16px;
     background-image: url("sort_asc_inverse.svg");
-    flex: 0 0 auto;
-    margin-right: 2px;
-    background-color: transparent;
-    border: 0px;
-    padding: 0px;
 }
 
 .slick-header-menubutton {

src/reactviews/pages/QueryResult/resultGrid.tsx

@@ -234,7 +234,6 @@ const ResultGrid = forwardRef<ResultGridHandle, ResultGridProps>(
                 showRowNumber: true,
                 forceFitColumns: false,
                 defaultColumnWidth: COLUMN_WIDTH,
-                // multiColumnSort: true,
             };
             let rowNumberColumn = new RowNumberColumn<Slick.SlickData>({
                 autoCellSelection: false,

src/reactviews/pages/QueryResult/table/hybridDataProvider.ts

@@ -117,7 +117,6 @@ export class HybridDataProvider<T extends Slick.SlickData>
     }
 
     public async resetSort() {
-        // const data = await this._loadDataFn(0, this.length);
         void this.provider.resetSort();
     }
 

src/reactviews/pages/QueryResult/table/tableDataView.ts

@@ -168,7 +168,6 @@ export class TableDataView<T extends Slick.SlickData>
         this._currentColumnFilters = columns!;
         this._data = this._filterFn!(this._allData, columns!);
         if (this._resetSortData.length > 0) {
-            // this._resetDataUnfiltered = new Array(...this._resetSortData);
             this._resetSortData = this._filterFn!(
                 this._resetSortData,
                 columns!,
@@ -191,7 +190,6 @@ export class TableDataView<T extends Slick.SlickData>
             this._allData = [];
             this._filterEnabled = false;
             if (this._currentColumnSort) {
-                // this._resetDataUnfiltered = new Array(...this._data);
                 this._data = this._sortFn!(
                     {
                         sortCol: this._currentColumnSort.column,

typings/slickgrid.d.ts

@@ -1439,7 +1439,6 @@ declare namespace Slick {
 
 		// Single column returned
 		sortCol?: Column<T>;
-		//TODO: change this to 3 states?
 		sortAsc: boolean;
 
 		// Multiple columns returned