consolidating updateState() calls (#18138)

Author: Benjin

src/controllers/executionPlanWebviewController.ts

@@ -165,8 +165,4 @@ export class ExecutionPlanWebviewController extends ReactWebviewPanelController<
         }
         return sum;
     }
-
-    private updateState() {
-        this.state = this.state;
-    }
 }

src/controllers/reactWebviewBaseController.ts

@@ -285,6 +285,14 @@ export abstract class ReactWebviewBaseController<State, Reducers>
         this.postNotification(DefaultWebviewNotifications.updateState, value);
     }
 
+    /**
+     * Updates the state in the webview
+     * @param state The new state object.  If not provided, `this.state` is used.
+     */
+    public updateState(state?: State) {
+        this.state = state ?? this.state;
+    }
+
     /**
      * Gets whether the controller has been disposed
      */

src/nps/userSurvey.ts

@@ -232,10 +232,6 @@ class UserSurveyWebviewController extends ReactWebviewPanelController<
             this._onCancel.fire();
         });
     }
-
-    updateState(state: UserSurveyState): void {
-        this.state = state;
-    }
 }
 
 export function getStandardNPSQuestions(featureName?: string): UserSurveyState {